Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 10546071: CapturingNetLog - remove maximum entries constructor argument. (Closed)

Created:
8 years, 6 months ago by mmenke
Modified:
8 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, darin-cc_chromium.org
Visibility:
Public.

Description

CapturingNetLog - remove maximum entries constructor argument. Also replace with a NULL NetLog in a couple callsites where it wasn't being used. R=eroman@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141315

Patch Set 1 #

Total comments: 4

Patch Set 2 : Response to comments, sync #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -161 lines) Patch
M net/base/capturing_net_log.h View 1 2 3 chunks +2 lines, -8 lines 0 comments Download
M net/base/capturing_net_log.cc View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M net/base/net_log_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_network_transaction_spdy2_unittest.cc View 1 2 19 chunks +19 lines, -19 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 1 2 26 chunks +26 lines, -26 lines 0 comments Download
M net/proxy/multi_threaded_proxy_resolver_unittest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M net/proxy/proxy_resolver_js_bindings_unittest.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M net/proxy/proxy_script_decider_unittest.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M net/proxy/proxy_service_unittest.cc View 1 2 9 chunks +9 lines, -19 lines 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 1 2 17 chunks +17 lines, -17 lines 0 comments Download
M net/socket/socks5_client_socket_unittest.cc View 1 2 6 chunks +5 lines, -6 lines 0 comments Download
M net/socket/socks_client_socket_unittest.cc View 1 2 12 chunks +12 lines, -12 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M net/socket/transport_client_socket_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_spdy2_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_spdy3_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_spdy2_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_spdy3_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream_spdy2_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream_spdy3_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/udp/udp_socket_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mmenke
I also removed unneeded use of CapturingNetLogs in a couple of tests, but left those ...
8 years, 6 months ago (2012-06-08 16:09:34 UTC) #1
mmenke
On 2012/06/08 16:09:34, Matt Menke wrote: > I also removed unneeded use of CapturingNetLogs in ...
8 years, 6 months ago (2012-06-08 16:10:34 UTC) #2
eroman
lgtm http://codereview.chromium.org/10546071/diff/1/net/base/capturing_net_log.h File net/base/capturing_net_log.h (left): http://codereview.chromium.org/10546071/diff/1/net/base/capturing_net_log.h#oldcode31 net/base/capturing_net_log.h:31: // TODO(mmenke): Move CapturingNetLog to net_unittests project, once ...
8 years, 6 months ago (2012-06-08 18:24:41 UTC) #3
mmenke
Thanks. http://codereview.chromium.org/10546071/diff/1/net/base/capturing_net_log.h File net/base/capturing_net_log.h (left): http://codereview.chromium.org/10546071/diff/1/net/base/capturing_net_log.h#oldcode31 net/base/capturing_net_log.h:31: // TODO(mmenke): Move CapturingNetLog to net_unittests project, once ...
8 years, 6 months ago (2012-06-08 18:28:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10546071/5009
8 years, 6 months ago (2012-06-08 22:09:36 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 22:57:34 UTC) #6
Change committed as 141315

Powered by Google App Engine
This is Rietveld 408576698