Issue 10546066: Fix jscompiler error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10546066: Fix jscompiler error. (Closed)

Created:
8 years, 6 months ago by Jamie

Modified:
8 years, 6 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix jscompiler error. BUG=None TEST=Manuel Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141150

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added explanatory comment. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	remoting/webapp/remoting.js	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

https://chromiumcodereview.appspot.com/10546066/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): https://chromiumcodereview.appspot.com/10546066/diff/1/remoting/webapp/remoting.js#newcode309 remoting/webapp/remoting.js:309: * @return {string} The number, formatted as a string ...

8 years, 6 months ago (2012-06-08 01:25:03 UTC) #2

Jamie

8 years, 6 months ago (2012-06-08 01:31:18 UTC) #4

fyi

https://chromiumcodereview.appspot.com/10546066/diff/1/remoting/webapp/remoti...
File remoting/webapp/remoting.js (right):

https://chromiumcodereview.appspot.com/10546066/diff/1/remoting/webapp/remoti...
remoting/webapp/remoting.js:309: * @return {string} The number, formatted as a
string of the specified length.
On 2012/06/08 01:25:03, sergeyu wrote:
> nit: maybe explain that this function does it by prepending zeroes to the
> string.

Done.

Expand Messages | Collapse Messages