Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10546063: Update touch_200_percent assets (Closed)

Created:
8 years, 6 months ago by benrg
Modified:
8 years, 6 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Update touch_200_percent assets These new assets are from the zip file attached to issue 131658. Four of those images were renamed for consistency: theme_default_active.png => theme_frame_default_active.png theme_default_inactive.png => theme_frame_default_inactive.png incognito-switch-off.png => incognito_switch_off.png incognito-switch-on.png => incognito_switch_on.png Five of them are new: otr_icon.png otr_icon_fullscreen.png incognito_background.png incognito_switch_off.png incognito_switch_on.png In a separate CL I will update the GRD file to point to the first of these (currently it points to the version in touch_100_percent). The other four do not have resource IDs yet and the GRD file will not be updated yet. TBR=sky@chromium.org BUG=131658 TEST=Compare old and new images and check that they all look similar to each other Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141174

Patch Set 1 : for review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-79 lines, --79 lines) Patch
M chrome/app/theme/touch_200_percent/browser_action_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_action_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_action_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_actions_overflow_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_actions_overflow_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_actions_overflow_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_back_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_back_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_back_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_back_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_forward_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_forward_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_forward_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_forward_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_home_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_home_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_home_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_omnibox_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_omnibox_middle.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_omnibox_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_reload_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_reload_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_reload_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_reload_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_stop_disabled.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_stop_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_stop_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_stop_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_tools_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_tools_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/browser_tools_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_200_percent/incognito_background.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_200_percent/incognito_switch_off.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_200_percent/incognito_switch_on.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/newtab_button_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/newtab_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/newtab_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/newtab_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_200_percent/otr_icon.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/touch_200_percent/otr_icon_fullscreen.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_active_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_active_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_active_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_alpha_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_alpha_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_close_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_close_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_close_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_close_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_inactive_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_inactive_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/tab_inactive_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/theme_frame_default_active.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/theme_frame_default_inactive.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/toolbar_shade_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/toolbar_shade_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/toolbar_shade_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/toolbar_shade_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/toolbar_shade_line.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/toolbar_shade_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/touch_200_percent/toolbar_shade_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_hover_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/touch_200_percent/textbutton_pressed_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
benrg
8 years, 6 months ago (2012-06-07 22:24:35 UTC) #1
oshima
LGTM Sorry I forgot to say that you can tbr png only change.
8 years, 6 months ago (2012-06-08 00:31:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benrg@chromium.org/10546063/1085
8 years, 6 months ago (2012-06-08 00:46:42 UTC) #3
commit-bot: I haz the power
Try job failure for 10546063-1085 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=30988 Step "update" is always ...
8 years, 6 months ago (2012-06-08 00:49:56 UTC) #4
benrg
8 years, 6 months ago (2012-06-08 21:26:23 UTC) #5 
Sky: just adds/replaces images, already committed.

Powered by Google App Engine
This is Rietveld 408576698