Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1604)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 10546044: [Metrics] Re-try failed protocol buffer uploads as well as failed XML uploads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Why do today what you can put off 'til tomorrow? Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | chrome/browser/metrics/metrics_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index 2e8e83d801e5f0271444e427ff9765ea740da46c..364c3f7bc98ef0efcebcc20e8ff4ce3565d3e9c5 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -291,7 +291,7 @@ class MetricsService
// Logs debugging details, for the case where the server returns a response
// code other than 200.
- void LogBadResponseCode();
+ void LogBadResponseCode(int response_code, bool is_xml);
// Records a window-related notification.
void LogWindowChange(int type,
@@ -395,12 +395,6 @@ class MetricsService
scoped_ptr<net::URLFetcher> current_fetch_xml_;
scoped_ptr<net::URLFetcher> current_fetch_proto_;
- // Cached responses from the XML request while we wait for a response to the
- // protubuf request.
- int response_code_;
- std::string response_status_;
- std::string response_data_;
-
// The URLs for the XML and protobuf metrics servers.
string16 server_url_xml_;
string16 server_url_proto_;
« no previous file with comments | « no previous file | chrome/browser/metrics/metrics_service.cc » ('j') | chrome/browser/metrics/metrics_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698