Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: chrome/common/metrics/metrics_log_manager.cc

Issue 10546044: [Metrics] Re-try failed protocol buffer uploads as well as failed XML uploads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert DiscardStagedLog() visibility change Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/metrics/metrics_log_manager.h ('k') | chrome/common/metrics/metrics_log_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics/metrics_log_manager.cc
diff --git a/chrome/common/metrics/metrics_log_manager.cc b/chrome/common/metrics/metrics_log_manager.cc
index e78ce89e152419e09669e77c104c7ab8b9f9ad03..554cb2d2522449e4b260ab1ff7ab03f06b72a43d 100644
--- a/chrome/common/metrics/metrics_log_manager.cc
+++ b/chrome/common/metrics/metrics_log_manager.cc
@@ -87,11 +87,17 @@ void MetricsLogManager::StageNextLogForUpload() {
}
bool MetricsLogManager::has_staged_log() const {
- return !staged_log_text().empty();
+ return has_staged_log_proto() || has_staged_log_xml();
}
bool MetricsLogManager::has_staged_log_proto() const {
- return has_staged_log() && staged_log_text().proto != kDiscardedLog;
+ return !staged_log_text().proto.empty() &&
+ staged_log_text().proto != kDiscardedLog;
+}
+
+bool MetricsLogManager::has_staged_log_xml() const {
+ return !staged_log_text().xml.empty() &&
+ staged_log_text().xml != kDiscardedLog;
}
void MetricsLogManager::DiscardStagedLog() {
@@ -102,6 +108,18 @@ void MetricsLogManager::DiscardStagedLog() {
void MetricsLogManager::DiscardStagedLogProto() {
staged_log_text_.proto = kDiscardedLog;
+
+ // If we're discarding the last piece of the log, reset the staged log state.
+ if (!has_staged_log())
+ DiscardStagedLog();
+}
+
+void MetricsLogManager::DiscardStagedLogXml() {
+ staged_log_text_.xml = kDiscardedLog;
+
+ // If we're discarding the last piece of the log, reset the staged log state.
+ if (!has_staged_log())
+ DiscardStagedLog();
}
void MetricsLogManager::DiscardCurrentLog() {
« no previous file with comments | « chrome/common/metrics/metrics_log_manager.h ('k') | chrome/common/metrics/metrics_log_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698