Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 10546025: Delete empty NotificationObserverLists. Fixes leak. (Closed)

Created:
8 years, 6 months ago by lengG
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Delete empty NotificationObserverLists. Fixes leak. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141010

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback: removed unnecessary = NULL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/browser/notification_service_impl.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lengG
8 years, 6 months ago (2012-06-06 16:07:55 UTC) #1
jam
lgtm http://codereview.chromium.org/10546025/diff/1/content/browser/notification_service_impl.cc File content/browser/notification_service_impl.cc (right): http://codereview.chromium.org/10546025/diff/1/content/browser/notification_service_impl.cc#newcode85 content/browser/notification_service_impl.cc:85: observer_list = NULL; nit: unnecessary
8 years, 6 months ago (2012-06-06 16:48:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@google.com/10546025/4001
8 years, 6 months ago (2012-06-07 14:08:05 UTC) #3
lengG
Thanks for the review! https://chromiumcodereview.appspot.com/10546025/diff/1/content/browser/notification_service_impl.cc File content/browser/notification_service_impl.cc (right): https://chromiumcodereview.appspot.com/10546025/diff/1/content/browser/notification_service_impl.cc#newcode85 content/browser/notification_service_impl.cc:85: observer_list = NULL; On 2012/06/06 ...
8 years, 6 months ago (2012-06-07 14:08:51 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-07 15:31:41 UTC) #5
Change committed as 141010

Powered by Google App Engine
This is Rietveld 408576698