Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10546024: Add RootWindowController (Closed)

Created:
8 years, 6 months ago by oshima
Modified:
8 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Reland r141871. Add RootWindowController that keeps per root window state. Cleanup Shell::Init(). Separated initialization that are specific to shell, root window and primary display. I also did small cleanup in detor. I'll do more cleanups when I have a chance. BUG=123160 TEST=no functional change. all tests should pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141881

Patch Set 1 #

Patch Set 2 : not for review #

Patch Set 3 : . #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Total comments: 16

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+480 lines, -285 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M ash/launcher/launcher_context_menu.cc View 1 3 chunks +8 lines, -7 lines 0 comments Download
A ash/root_window_controller.h View 1 2 3 4 5 1 chunk +84 lines, -0 lines 0 comments Download
A ash/root_window_controller.cc View 1 2 3 1 chunk +218 lines, -0 lines 0 comments Download
M ash/shell.h View 1 2 3 4 5 13 chunks +16 lines, -22 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 19 chunks +91 lines, -238 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/property_util.h View 1 2 3 chunks +11 lines, -0 lines 0 comments Download
M ash/wm/property_util.cc View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download
M ash/wm/screen_dimmer.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/window_properties.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/window_properties.cc View 1 3 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/window_util.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/power/screen_dimming_observer.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
http://codereview.chromium.org/10546024/diff/14002/ash/shell.cc File ash/shell.cc (right): http://codereview.chromium.org/10546024/diff/14002/ash/shell.cc#newcode397 ash/shell.cc:397: // RootWindowController as possible. I'll do this in separate ...
8 years, 6 months ago (2012-06-13 00:35:22 UTC) #1
oshima
http://codereview.chromium.org/10546024/diff/14002/chrome/browser/chromeos/power/screen_dimming_observer.cc File chrome/browser/chromeos/power/screen_dimming_observer.cc (right): http://codereview.chromium.org/10546024/diff/14002/chrome/browser/chromeos/power/screen_dimming_observer.cc#newcode23 chrome/browser/chromeos/power/screen_dimming_observer.cc:23: ash::Shell::GetPrimaryRootWindowController()->screen_dimmer()->SetDimming( Oops, I was going to define Shell::SetDimming. Please ...
8 years, 6 months ago (2012-06-13 00:46:09 UTC) #2
oshima
uploaded new patch. PTAL. http://codereview.chromium.org/10546024/diff/14002/ash/tooltips/tooltip_controller.cc File ash/tooltips/tooltip_controller.cc (left): http://codereview.chromium.org/10546024/diff/14002/ash/tooltips/tooltip_controller.cc#oldcode107 ash/tooltips/tooltip_controller.cc:107: widget_->Activate(); This wasn't necessary.
8 years, 6 months ago (2012-06-13 00:57:19 UTC) #3
Daniel Erat
lgtm http://codereview.chromium.org/10546024/diff/13004/ash/root_window_controller.h File ash/root_window_controller.h (right): http://codereview.chromium.org/10546024/diff/13004/ash/root_window_controller.h#newcode34 ash/root_window_controller.h:34: // deleted open the deletion of the root ...
8 years, 6 months ago (2012-06-13 01:36:28 UTC) #4
oshima
8 years, 6 months ago (2012-06-13 05:52:37 UTC) #5 
http://codereview.chromium.org/10546024/diff/13004/ash/root_window_controller.h
File ash/root_window_controller.h (right):

http://codereview.chromium.org/10546024/diff/13004/ash/root_window_controller...
ash/root_window_controller.h:34: // deleted open the deletion of the root
window.  The RootWindowController
On 2012/06/13 01:36:28, Daniel Erat wrote:
> nit: s/open/upon/

Done.

http://codereview.chromium.org/10546024/diff/13004/ash/root_window_controller...
ash/root_window_controller.h:63: // Deletes all child windows and performs
necessary clean ups.
On 2012/06/13 01:36:28, Daniel Erat wrote:
> nit: s/clean ups/cleanup/

Done.

http://codereview.chromium.org/10546024/diff/13004/ash/root_window_controller...
ash/root_window_controller.h:66: // Returns true if the workspace has maximized
or fullscreen window.
On 2012/06/13 01:36:28, Daniel Erat wrote:
> nit: s/has maximized/has a maximized/

Done.

http://codereview.chromium.org/10546024/diff/13004/ash/shell.cc
File ash/shell.cc (right):

http://codereview.chromium.org/10546024/diff/13004/ash/shell.cc#newcode45
ash/shell.cc:45: //#include "ash/wm/property_util.h"
On 2012/06/13 01:36:28, Daniel Erat wrote:
> did you mean to delete this?

removed.

http://codereview.chromium.org/10546024/diff/13004/ash/shell.cc#newcode396
ash/shell.cc:396: // TODO(oshima): Move as much controllers before creating
On 2012/06/13 01:36:28, Daniel Erat wrote:
> nit: s/much/many/

Done.

http://codereview.chromium.org/10546024/diff/13004/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/10546024/diff/13004/ash/shell.h#newcode146
ash/shell.h:146: // Returns the root window controller for primary root window.
On 2012/06/13 01:36:28, Daniel Erat wrote:
> nit: s/for primary/for the primary/

Done.

http://codereview.chromium.org/10546024/diff/13004/ash/shell.h#newcode298
ash/shell.h:298: // Dim or undim the screen.
On 2012/06/13 01:36:28, Daniel Erat wrote:
> nit: Dims or undims

Done.

http://codereview.chromium.org/10546024/diff/13004/ash/wm/power_button_contro...
File ash/wm/power_button_controller.cc (right):

http://codereview.chromium.org/10546024/diff/13004/ash/wm/power_button_contro...
ash/wm/power_button_controller.cc:8: #include "ash/root_window_controller.h"
On 2012/06/13 01:36:28, Daniel Erat wrote:
> do you still need this?
removed

Powered by Google App Engine
This is Rietveld 408576698