compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 10545189: Issue 3643. Associate 'no such method' problem with method name, not with whole invocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10545189: Issue 3643. Associate 'no such method' problem with method name, not with whole invocation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Use 'resolutionError' flag in DartIdentifier Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/java/com/google/dart/compiler/ast/DartNode.java ('K') | « compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java » ('j') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index 2a64e2db03ab9ba2d8aa785973549c3aad80b00d..2b1c6c5b6077bff1ee6ad84e10bcb8cdb6f842f1 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -1143,7 +1143,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

DartNode target = node.getTarget();

Type receiver = nonVoidTypeOf(target);

List<DartExpression> arguments = node.getArguments();

- Member member = lookupMember(receiver, name, node);

+ Member member = lookupMember(receiver, name, node.getFunctionName());

if (member != null) {

node.setElement(member.getElement());

}

@@ -2120,7 +2120,9 @@ public class TypeAnalyzer implements DartCompilationPhase {

type = typeAsMemberOf(element, currentClass);

break;

case NONE:

- // already reported by resolver

+ if (!target.hasResolutionError()) {

+ onError(target, TypeErrorCode.INTERFACE_HAS_NO_METHOD_NAMED, currentClass, target);

+ }

return dynamicType;

default:

type = element.getType();