Issue 3643. Associate 'no such method' problem with method name, not with whole invocation

compiler/java/com/google/dart/compiler/ast/DartIdentifier.java

Index: compiler/java/com/google/dart/compiler/ast/DartIdentifier.java
diff --git a/compiler/java/com/google/dart/compiler/ast/DartIdentifier.java b/compiler/java/com/google/dart/compiler/ast/DartIdentifier.java
index 8c918e336ab2416095d991ecc272d31b1760ebcc..9aeea4a38566409bbfce647ebce924ece6182ed0 100644
--- a/compiler/java/com/google/dart/compiler/ast/DartIdentifier.java
+++ b/compiler/java/com/google/dart/compiler/ast/DartIdentifier.java
@@ -14,6 +14,7 @@ public class DartIdentifier extends DartExpression {
 
   private final String name;
   private NodeElement element;
+  private boolean hasResolutionError;

[Brian Wilkerson, 2012/06/15 18:18:45]

Definitely better than the other solutions, but I still don't like it much. The
one change I would request at this point is that we make the name of the field
very specific so that it's clear that this should not be used for any other
kinds of resolution errors. Perhaps something as ugly as
"resolutionAlreadyReportedThatTheMethodCouldNotBeFound", but something that will
make it clear that this is intended for a very specific case.

[scheglov, 2012/06/15 18:46:09]

I like this name!

 
   public DartIdentifier(String name) {
     assert name != null;
@@ -43,6 +44,21 @@ public class DartIdentifier extends DartExpression {
     this.element = (NodeElement) element;
   }
 
+  /**
+   * Specifies that this name was not found it enclosing {@link Element}.
+   */
+  public void markResolutionError() {
+    this.hasResolutionError = true;
+  }
+  
+  /**
+   * @return <code>true</code> if we know that this name was not found in its enclosing
+   *         {@link Element}, and error was already reported.
+   */
+  public boolean hasResolutionError() {
+    return hasResolutionError;
+  }
+
   @Override
   public void visitChildren(ASTVisitor<?> visitor) {
   }