Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 10545186: Improve equality operation (inline, direct calls). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 8675)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -623,15 +623,16 @@
void FlowGraphOptimizer::VisitEqualityCompare(EqualityCompareComp* comp) {
- if (!comp->HasICData()) return;
- const ICData& ic_data = *comp->ic_data();
- if (ic_data.NumberOfChecks() != 1) return;
- ASSERT(HasOneTarget(ic_data));
- if (HasTwoSmi(ic_data)) {
- comp->set_operands_class_id(kSmi);
- } else {
- return;
+ const intptr_t kMaxChecks = 4;
+ if (comp->ic_data()->num_args_tested() <= kMaxChecks) {
+ ZoneGrowableArray<intptr_t>* class_ids =
+ new ZoneGrowableArray<intptr_t>();
+ ZoneGrowableArray<Function*>* targets =
+ new ZoneGrowableArray<Function*>();
+ ExtractClassIdsAndTargets(*comp->ic_data(), class_ids, targets);
+ comp->SetPolymorphicTargets(class_ids, targets);
}
+
// TODO(vegorov): recognize the pattern with BooleanNegate between comparsion
// and a branch.
TryFuseComparisonWithBranch(comp);

Powered by Google App Engine
This is Rietveld 408576698