Issue 10545181: Optimizes loading initial printer on non-chromeos platforms.

Issue 10545181: Optimizes loading initial printer on non-chromeos platforms. (Closed)

Created:
8 years, 6 months ago by Robert Toscano

Modified:
8 years, 6 months ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Optimizes loading initial printer on non-chromeos platforms. BUG=131327 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142226

Patch Set 2 : Updates browser tests. #

Patch Set 3 : Add bug reference to TODOs. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -38 lines)			Patch
M	chrome/browser/printing/print_system_task_proxy.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/print_preview/data/destination_store.js	View	1 2	2 chunks	+33 lines, -13 lines	0 comments	Download
M	chrome/browser/resources/print_preview/search/destination_search.js	View		4 chunks	+27 lines, -25 lines	0 comments	Download
M	chrome/test/data/webui/print_preview.js	View	1	16 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Robert Toscano

Reinstates the initial-printer load optimization. In order to make this work robustly, I had to ...

8 years, 6 months ago (2012-06-14 17:48:13 UTC) #1

Albert Bodenhamer

lgtm http://codereview.chromium.org/10545181/diff/1/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): http://codereview.chromium.org/10545181/diff/1/chrome/browser/resources/print_preview/data/destination_store.js#newcode192 chrome/browser/resources/print_preview/data/destination_store.js:192: // information about the initially selected printer so ...

8 years, 6 months ago (2012-06-14 18:00:24 UTC) #2

Robert Toscano

On 2012/06/14 18:00:24, Albert Bodenhamer wrote: > lgtm > > http://codereview.chromium.org/10545181/diff/1/chrome/browser/resources/print_preview/data/destination_store.js > File chrome/browser/resources/print_preview/data/destination_store.js (right): ...

8 years, 6 months ago (2012-06-14 19:19:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rltoscano@google.com/10545181/4002

8 years, 6 months ago (2012-06-14 19:20:09 UTC) #4

Change committed as 142226

Expand Messages | Collapse Messages