Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10545176: Only do the declaring of parameters in a non-bailout version. The bailout version has different set… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/codegen.dart
===================================================================
--- lib/compiler/implementation/ssa/codegen.dart (revision 8652)
+++ lib/compiler/implementation/ssa/codegen.dart (working copy)
@@ -215,9 +215,6 @@
equalsNullElement = interceptors.getEqualsNullInterceptor();
boolifiedEqualsNullElement =
interceptors.getBoolifiedVersionOf(equalsNullElement);
- parameterNames.forEach((Element element, String name) {
- declaredVariables.add(name);
- });
}
abstract visitTypeGuard(HTypeGuard node);
@@ -2468,7 +2465,13 @@
class SsaOptimizedCodeGenerator extends SsaCodeGenerator {
SsaOptimizedCodeGenerator(backend, work, parameters, parameterNames)
- : super(backend, work, parameters, parameterNames);
+ : super(backend, work, parameters, parameterNames) {
+ // Declare the parameter names only for the optimized version. The
+ // unoptimized version has different parameters.
+ parameterNames.forEach((Element element, String name) {
+ declaredVariables.add(name);
+ });
+ }
int maxBailoutParameters;
@@ -2700,6 +2703,9 @@
// call site for non-complex bailout methods.
newParameters.add('state');
+ // TODO(ngeoffray): We should declare the parameters in
+ // beginGraph, to avoid potentially redeclaring them with 'var'
+ // in the method body.
if (!propagator.hasComplexTypeGuards) {
propagator.firstTypeGuard.block.first = savedFirstInstruction;
for (HInstruction input in propagator.firstTypeGuard.inputs) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698