Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: sync/notifier/push_client_channel.h

Issue 10545170: [Sync] Propagate XMPP auth errors to SyncNotifierObservers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix deps, win compile error Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/push_client_channel.h
diff --git a/sync/notifier/push_client_channel.h b/sync/notifier/push_client_channel.h
index 1721def63fc16bdb42968b7970facfb97aa75117..8ad185309ac7601ad02ab362f38a9b466f17b705 100644
--- a/sync/notifier/push_client_channel.h
+++ b/sync/notifier/push_client_channel.h
@@ -27,6 +27,8 @@ class PushClientChannel
: public invalidation::NetworkChannel,
public notifier::PushClientObserver {
public:
+ // |push_client| is guaranteed to be destroyed only when this object
+ // is destroyed.
explicit PushClientChannel(scoped_ptr<notifier::PushClient> push_client);
virtual ~PushClientChannel();
@@ -46,7 +48,9 @@ class PushClientChannel
invalidation::SystemResources* resources) OVERRIDE;
// notifier::PushClient::Observer implementation.
- virtual void OnNotificationStateChange(bool notifications_enabled) OVERRIDE;
+ virtual void OnNotificationsEnabled() OVERRIDE;
+ virtual void OnNotificationsDisabled(
+ notifier::NotificationsDisabledReason reason) OVERRIDE;
virtual void OnIncomingNotification(
const notifier::Notification& notification) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698