Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: sync/notifier/non_blocking_invalidation_notifier.cc

Issue 10545170: [Sync] Propagate XMPP auth errors to SyncNotifierObservers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix deps, win compile error Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/non_blocking_invalidation_notifier.cc
diff --git a/sync/notifier/non_blocking_invalidation_notifier.cc b/sync/notifier/non_blocking_invalidation_notifier.cc
index f9a7bd13787ff2fff020b0839eb2ac4f7fe8aaea..a92bd66430b35dec586992813aa636b1543cdb5b 100644
--- a/sync/notifier/non_blocking_invalidation_notifier.cc
+++ b/sync/notifier/non_blocking_invalidation_notifier.cc
@@ -42,10 +42,12 @@ class NonBlockingInvalidationNotifier::Core
// SyncNotifierObserver implementation (all called on I/O thread by
// InvalidationNotifier).
+ virtual void OnNotificationsEnabled() OVERRIDE;
+ virtual void OnNotificationsDisabled(
+ NotificationsDisabledReason reason) OVERRIDE;
virtual void OnIncomingNotification(
const syncable::ModelTypePayloadMap& type_payloads,
- IncomingNotificationSource source);
- virtual void OnNotificationStateChange(bool notifications_enabled);
+ IncomingNotificationSource source) OVERRIDE;
private:
friend class
@@ -126,22 +128,27 @@ void NonBlockingInvalidationNotifier::Core::UpdateEnabledTypes(
invalidation_notifier_->UpdateEnabledTypes(enabled_types);
}
-void NonBlockingInvalidationNotifier::Core::OnIncomingNotification(
- const syncable::ModelTypePayloadMap& type_payloads,
- IncomingNotificationSource source) {
+void NonBlockingInvalidationNotifier::Core::OnNotificationsEnabled() {
DCHECK(network_task_runner_->BelongsToCurrentThread());
delegate_observer_.Call(FROM_HERE,
- &SyncNotifierObserver::OnIncomingNotification,
- type_payloads,
- source);
+ &SyncNotifierObserver::OnNotificationsEnabled);
}
-void NonBlockingInvalidationNotifier::Core::OnNotificationStateChange(
- bool notifications_enabled) {
+void NonBlockingInvalidationNotifier::Core::OnNotificationsDisabled(
+ NotificationsDisabledReason reason) {
+ DCHECK(network_task_runner_->BelongsToCurrentThread());
+ delegate_observer_.Call(
+ FROM_HERE, &SyncNotifierObserver::OnNotificationsDisabled, reason);
+}
+
+void NonBlockingInvalidationNotifier::Core::OnIncomingNotification(
+ const syncable::ModelTypePayloadMap& type_payloads,
+ IncomingNotificationSource source) {
DCHECK(network_task_runner_->BelongsToCurrentThread());
delegate_observer_.Call(FROM_HERE,
- &SyncNotifierObserver::OnNotificationStateChange,
- notifications_enabled);
+ &SyncNotifierObserver::OnIncomingNotification,
+ type_payloads,
+ source);
}
NonBlockingInvalidationNotifier::NonBlockingInvalidationNotifier(
@@ -247,19 +254,25 @@ void NonBlockingInvalidationNotifier::SendNotification(
// need to forward on the call.
}
-void NonBlockingInvalidationNotifier::OnIncomingNotification(
- const syncable::ModelTypePayloadMap& type_payloads,
- IncomingNotificationSource source) {
+void NonBlockingInvalidationNotifier::OnNotificationsEnabled() {
DCHECK(parent_task_runner_->BelongsToCurrentThread());
FOR_EACH_OBSERVER(SyncNotifierObserver, observers_,
- OnIncomingNotification(type_payloads, source));
+ OnNotificationsEnabled());
+}
+
+void NonBlockingInvalidationNotifier::OnNotificationsDisabled(
+ NotificationsDisabledReason reason) {
+ DCHECK(parent_task_runner_->BelongsToCurrentThread());
+ FOR_EACH_OBSERVER(SyncNotifierObserver, observers_,
+ OnNotificationsDisabled(reason));
}
-void NonBlockingInvalidationNotifier::OnNotificationStateChange(
- bool notifications_enabled) {
+void NonBlockingInvalidationNotifier::OnIncomingNotification(
+ const syncable::ModelTypePayloadMap& type_payloads,
+ IncomingNotificationSource source) {
DCHECK(parent_task_runner_->BelongsToCurrentThread());
FOR_EACH_OBSERVER(SyncNotifierObserver, observers_,
- OnNotificationStateChange(notifications_enabled));
+ OnIncomingNotification(type_payloads, source));
}
} // namespace sync_notifier

Powered by Google App Engine
This is Rietveld 408576698