Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: sync/notifier/invalidation_notifier_unittest.cc

Issue 10545170: [Sync] Propagate XMPP auth errors to SyncNotifierObservers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix deps, win compile error Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/invalidation_notifier_unittest.cc
diff --git a/sync/notifier/invalidation_notifier_unittest.cc b/sync/notifier/invalidation_notifier_unittest.cc
index 16b70c1ab946e304aa89848a3a42f1d79893b093..9bd18403a8c21c6e4e99c6a5f76229347c3f12ae 100644
--- a/sync/notifier/invalidation_notifier_unittest.cc
+++ b/sync/notifier/invalidation_notifier_unittest.cc
@@ -80,11 +80,14 @@ TEST_F(InvalidationNotifierTest, Basic) {
type_payloads[syncable::BOOKMARKS] = "";
type_payloads[syncable::AUTOFILL] = "";
- EXPECT_CALL(mock_observer_, OnNotificationStateChange(true));
+ EXPECT_CALL(mock_observer_, OnNotificationsEnabled());
EXPECT_CALL(mock_observer_,
OnIncomingNotification(type_payloads,
REMOTE_NOTIFICATION));
- EXPECT_CALL(mock_observer_, OnNotificationStateChange(false));
+ EXPECT_CALL(mock_observer_,
+ OnNotificationsDisabled(TRANSIENT_NOTIFICATION_ERROR));
+ EXPECT_CALL(mock_observer_,
+ OnNotificationsDisabled(NOTIFICATION_CREDENTIALS_REJECTED));
// Note no expectation on mock_tracker_, as we initialized with
// non-empty initial_invalidation_state above.
@@ -94,11 +97,14 @@ TEST_F(InvalidationNotifierTest, Basic) {
invalidation_notifier_->SetUniqueId("fake_id");
invalidation_notifier_->UpdateCredentials("foo@bar.com", "fake_token");
- invalidation_notifier_->OnSessionStatusChanged(true);
+ invalidation_notifier_->OnNotificationsEnabled();
invalidation_notifier_->OnInvalidate(type_payloads);
- invalidation_notifier_->OnSessionStatusChanged(false);
+ invalidation_notifier_->OnNotificationsDisabled(
+ TRANSIENT_NOTIFICATION_ERROR);
+ invalidation_notifier_->OnNotificationsDisabled(
+ NOTIFICATION_CREDENTIALS_REJECTED);
}
TEST_F(InvalidationNotifierTest, MigrateState) {

Powered by Google App Engine
This is Rietveld 408576698