[Sync] Propagate XMPP auth errors to SyncNotifierObservers

sync/notifier/chrome_invalidation_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/message_loop.h"
 #include "google/cacheinvalidation/include/invalidation-client.h"
 #include "google/cacheinvalidation/include/types.h"
 #include "google/cacheinvalidation/v2/types.pb.h"
 #include "jingle/notifier/listener/fake_push_client.h"
 #include "sync/internal_api/public/syncable/model_type.h"
 #include "sync/internal_api/public/syncable/model_type_payload_map.h"
 #include "sync/notifier/chrome_invalidation_client.h"
 #include "sync/notifier/mock_invalidation_state_tracker.h"
 #include "sync/util/weak_handle.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace sync_notifier {
 
 using ::testing::_;
+using ::testing::InSequence;
 using ::testing::Return;
 using ::testing::StrictMock;
 
 namespace {
 
 const char kClientId[] = "client_id";
 const char kClientInfo[] = "client_info";
 const char kState[] = "state";
 const char kNewState[] = "new_state";
 
 class MockInvalidationClient : public invalidation::InvalidationClient {
  public:
   MOCK_METHOD0(Start, void());
   MOCK_METHOD0(Stop, void());
   MOCK_METHOD1(Register, void(const invalidation::ObjectId&));
   MOCK_METHOD1(Register, void(const std::vector<invalidation::ObjectId>&));
   MOCK_METHOD1(Unregister, void(const invalidation::ObjectId&));
   MOCK_METHOD1(Unregister, void(const std::vector<invalidation::ObjectId>&));
   MOCK_METHOD1(Acknowledge, void(const invalidation::AckHandle&));
 };
 
 class MockListener : public ChromeInvalidationClient::Listener {
  public:
   MOCK_METHOD1(OnInvalidate, void(const syncable::ModelTypePayloadMap&));
-  MOCK_METHOD1(OnSessionStatusChanged, void(bool));
+  MOCK_METHOD1(OnSyncNotifierStateChange, void(SyncNotifierState));
 };
 
 }  // namespace
 
 class ChromeInvalidationClientTest : public testing::Test {
  protected:
   ChromeInvalidationClientTest()
-      : client_(
-          scoped_ptr<notifier::PushClient>(
-              new notifier::FakePushClient())) {}
+      : fake_push_client_(new notifier::FakePushClient()),
+        client_(scoped_ptr<notifier::PushClient>(fake_push_client_)) {}
 
   virtual void SetUp() {
     client_.Start(kClientId, kClientInfo, kState,
                   InvalidationVersionMap(),
                   browser_sync::MakeWeakHandle(
                       mock_invalidation_state_tracker_.AsWeakPtr()),
                   &mock_listener_);
   }
 
   virtual void TearDown() {
@@ skipping 41 matching lines @@
     invalidation::AckHandle ack_handle("fakedata");
     EXPECT_CALL(mock_invalidation_client_, Acknowledge(ack_handle));
     client_.InvalidateAll(&mock_invalidation_client_, ack_handle);
   }
 
   MessageLoop message_loop_;
   StrictMock<MockListener> mock_listener_;
   StrictMock<MockInvalidationStateTracker>
       mock_invalidation_state_tracker_;
   StrictMock<MockInvalidationClient> mock_invalidation_client_;
+  notifier::FakePushClient* const fake_push_client_;
   ChromeInvalidationClient client_;
 };
 
 namespace {
 
 syncable::ModelTypePayloadMap MakeMap(syncable::ModelType model_type,
                                       const std::string& payload) {
   syncable::ModelTypePayloadMap type_payloads;
   type_payloads[model_type] = payload;
   return type_payloads;
@@ skipping 23 matching lines @@
 }
 
 TEST_F(ChromeInvalidationClientTest, InvalidateWithPayload) {
   EXPECT_CALL(mock_listener_,
               OnInvalidate(MakeMap(syncable::PREFERENCES, "payload")));
   EXPECT_CALL(mock_invalidation_state_tracker_,
               SetMaxVersion(syncable::PREFERENCES, 1));
   FireInvalidate("PREFERENCE", 1, "payload");
 }
 
-TEST_F(ChromeInvalidationClientTest, WriteState) {
-  EXPECT_CALL(mock_invalidation_state_tracker_,
-              SetInvalidationState(kNewState));
-  client_.WriteState(kNewState);
-}
-
 TEST_F(ChromeInvalidationClientTest, InvalidateVersion) {
   using ::testing::Mock;
 
   EXPECT_CALL(mock_listener_,
               OnInvalidate(MakeMap(syncable::APPS, "")));
   EXPECT_CALL(mock_invalidation_state_tracker_,
               SetMaxVersion(syncable::APPS, 1));
 
   // Should trigger.
   FireInvalidate("APP", 1, NULL);
@@ skipping 81 matching lines @@
 TEST_F(ChromeInvalidationClientTest, RegisterTypes) {
   syncable::ModelTypeSet types(syncable::PREFERENCES, syncable::EXTENSIONS);
   client_.RegisterTypes(types);
   // Registered types should be preserved across Stop/Start.
   TearDown();
   SetUp();
   EXPECT_CALL(mock_listener_, OnInvalidate(MakeMapFromSet(types, "")));
   FireInvalidateAll();
 }
 
-// TODO(akalin): Flesh out unit tests.
+TEST_F(ChromeInvalidationClientTest, WriteState) {
+  EXPECT_CALL(mock_invalidation_state_tracker_,
+              SetInvalidationState(kNewState));
+  client_.WriteState(kNewState);
+}
+
+TEST_F(ChromeInvalidationClientTest, StateChangesNotReady) {
+  InSequence dummy;
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_OFF));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(CREDENTIALS_REJECTED));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_OFF));
+
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_OFF);
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::CREDENTIALS_REJECTED);
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_ON);
+}
+
+TEST_F(ChromeInvalidationClientTest, StateChangesReady) {
+  InSequence dummy;
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_OFF));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_ON));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_OFF));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(CREDENTIALS_REJECTED));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_ON));
+
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_ON);
+  client_.Ready(NULL);
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_OFF);
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::CREDENTIALS_REJECTED);
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_ON);
+}
+
+TEST_F(ChromeInvalidationClientTest, StateChangesAuthError) {
+  InSequence dummy;
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_OFF));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_ON));
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(CREDENTIALS_REJECTED)).Times(4);
+  EXPECT_CALL(mock_listener_,
+              OnSyncNotifierStateChange(NOTIFICATIONS_ON));
+
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_ON);
+  client_.Ready(NULL);
+
+  client_.InformError(
+      NULL,
+      invalidation::ErrorInfo(
+          invalidation::ErrorReason::AUTH_FAILURE,
+          false /* is_transient */,
+          "auth error",
+          invalidation::ErrorContext()));
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_OFF);
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::CREDENTIALS_REJECTED);
+  fake_push_client_->SimulatePushClientStateChange(
+      notifier::NOTIFICATIONS_ON);
+  client_.Ready(NULL);
+}
 
 }  // namespace sync_notifier