Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: net/base/cert_verify_proc_unittest.cc

Issue 10545166: Support SHA-256 in public key pins for HTTPS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/cert_verify_proc_unittest.cc
===================================================================
--- net/base/cert_verify_proc_unittest.cc (revision 141792)
+++ net/base/cert_verify_proc_unittest.cc (working copy)
@@ -399,10 +399,11 @@
std::string spki_sha1 = base::SHA1HashString(spki.as_string());
- std::vector<SHA1Fingerprint> public_keys;
- SHA1Fingerprint fingerprint;
- ASSERT_EQ(sizeof(fingerprint.data), spki_sha1.size());
- memcpy(fingerprint.data, spki_sha1.data(), spki_sha1.size());
+ std::vector<Fingerprint> public_keys;
+ Fingerprint fingerprint;
+ fingerprint.tag = FINGERPRINT_SHA1;
+ ASSERT_EQ(fingerprint.size(), spki_sha1.size());
+ memcpy(fingerprint.data(), spki_sha1.data(), spki_sha1.size());
public_keys.push_back(fingerprint);
EXPECT_TRUE(CertVerifyProc::IsPublicKeyBlacklisted(public_keys)) <<
@@ -470,9 +471,9 @@
EXPECT_EQ(0U, verify_result.cert_status);
ASSERT_LE(2u, verify_result.public_key_hashes.size());
EXPECT_EQ(HexEncode(kNistSPKIHash, base::kSHA1Length),
- HexEncode(verify_result.public_key_hashes[0].data, base::kSHA1Length));
+ HexEncode(verify_result.public_key_hashes[0].data(), base::kSHA1Length));
EXPECT_EQ("83244223D6CBF0A26FC7DE27CEBCA4BDA32612AD",
- HexEncode(verify_result.public_key_hashes[1].data, base::kSHA1Length));
+ HexEncode(verify_result.public_key_hashes[1].data(), base::kSHA1Length));
}
// A regression test for http://crbug.com/70293.

Powered by Google App Engine
This is Rietveld 408576698