Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: net/base/x509_cert_types.h

Issue 10545166: Support SHA-256 in public key pins for HTTPS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/x509_cert_types.h
===================================================================
--- net/base/x509_cert_types.h (revision 141792)
+++ net/base/x509_cert_types.h (working copy)
@@ -8,10 +8,12 @@
#include <string.h>
+#include <algorithm>
#include <set>
#include <string>
#include <vector>
+#include "base/logging.h"
#include "base/string_piece.h"
#include "build/build_config.h"
#include "net/base/net_export.h"
@@ -37,13 +39,6 @@
unsigned char data[20];
};
-// In the future there will be a generic Fingerprint type, with at least two
-// implementations: SHA1 and SHA256. See http://crbug.com/117914. Until that
-// work is done (in a separate patch) this typedef bridges the gap.
-typedef SHA1Fingerprint Fingerprint;
-
-typedef std::vector<Fingerprint> FingerprintVector;
-
class NET_EXPORT SHA1FingerprintLessThan {
public:
bool operator() (const SHA1Fingerprint& lhs,
@@ -52,6 +47,96 @@
}
};
+struct NET_EXPORT SHA256Fingerprint {
+ bool Equals(const SHA256Fingerprint& other) const {
+ return memcmp(data, other.data, sizeof(data)) == 0;
+ }
+
+ unsigned char data[32];
+};
+
+class NET_EXPORT SHA256FingerprintLessThan {
+ public:
+ bool operator() (const SHA256Fingerprint& lhs,
+ const SHA256Fingerprint& rhs) const {
+ return memcmp(lhs.data, rhs.data, sizeof(lhs.data)) < 0;
+ }
+};
+
+enum FingerprintTag {
+ FINGERPRINT_SHA1,
+ FINGERPRINT_SHA256,
+};
+
+struct NET_EXPORT Fingerprint {
+ bool Equals(const Fingerprint& other) const {
+ if (tag != other.tag)
+ return false;
+ switch (tag) {
+ case FINGERPRINT_SHA1:
+ return fingerprint.sha1.Equals(other.fingerprint.sha1);
+ break;
+ case FINGERPRINT_SHA256:
+ return fingerprint.sha256.Equals(other.fingerprint.sha256);
+ break;
+ default:
+ DCHECK(false) << "Unknown FingerprintTag " << tag;
+ return false;
+ }
+ }
+
+ size_t size() const {
+ switch (tag) {
+ case FINGERPRINT_SHA1:
+ return sizeof(fingerprint.sha1.data);
+ break;
+ case FINGERPRINT_SHA256:
+ return sizeof(fingerprint.sha256.data);
+ break;
+ default:
+ DCHECK(false) << "Unknown FingerprintTag " << tag;
+ return false;
+ }
+ }
+
+ unsigned char* data() const {
+ switch (tag) {
+ case FINGERPRINT_SHA1:
+ return const_cast<unsigned char*>(fingerprint.sha1.data);
+ break;
+ case FINGERPRINT_SHA256:
+ return const_cast<unsigned char*>(fingerprint.sha256.data);
+ break;
+ default:
+ DCHECK(false) << "Unknown FingerprintTag " << tag;
+ return NULL;
+ }
+ }
+
+ FingerprintTag tag;
+
+ union {
+ SHA1Fingerprint sha1;
+ SHA256Fingerprint sha256;
+ } fingerprint;
+};
+
+class NET_EXPORT FingerprintLessThan {
+ public:
+ bool operator() (const Fingerprint& lhs,
+ const Fingerprint& rhs) const {
+ size_t lhs_size = lhs.size();
+ size_t rhs_size = rhs.size();
+ int r = memcmp(lhs.data(), rhs.data(), std::min(lhs_size, rhs_size));
+
+ if (r == 0 && lhs_size != rhs_size)
+ return lhs_size < rhs_size;
+ return r < 0;
+ }
+};
+
+typedef std::vector<Fingerprint> FingerprintVector;
+
// IsSHA1HashInSortedArray returns true iff |hash| is in |array|, a sorted
// array of SHA1 hashes.
bool NET_EXPORT IsSHA1HashInSortedArray(const SHA1Fingerprint& hash,

Powered by Google App Engine
This is Rietveld 408576698