Issue 10545163: Make chrome use the win8 SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545163: Make chrome use the win8 SDK (Closed)

Created:
8 years, 6 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 5 months ago

Reviewers:
brettw, robertshield

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make chrome use the win8 SDK BUG=none TEST=it builds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145113

Patch Set 9 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	build/common.gypi	View	1 2 3 4 5 6 7 8	5 chunks	+11 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

http://codereview.chromium.org/10545163/diff/11001/base/win/i18n.cc File base/win/i18n.cc (right): http://codereview.chromium.org/10545163/diff/11001/base/win/i18n.cc#newcode52 base/win/i18n.cc:52: DWORD, PULONG, WCHAR*, PULONG); Here we test the theory ...

8 years, 6 months ago (2012-06-14 02:22:52 UTC) #1

cpu_(ooo_6.6-7.5)

I landed it temporarily on sunday expecting something to blow up but it didn't so ...

8 years, 5 months ago (2012-07-02 00:32:48 UTC) #2

Hironori Bono

8 years, 5 months ago (2012-07-02 02:15:07 UTC) #4

Greetings Carlos,

Out of curiosity, do we need to change our build instruction (*1) to make
developers (outside Google) install Windows SDK 8?

(*1) http://dev.chromium.org/developers/how-tos/build-instructions-windows

Regards,

Hironori Bono

Expand Messages | Collapse Messages

Issue 10545163: Make chrome use the win8 SDK (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Messages