Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 10545142: Remove root_window_ member from DesktopBackgroundController. (Closed)

Created:
8 years, 6 months ago by oshima
Modified:
8 years, 6 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove root_window_ member from DesktopBackgroundController. This will be changed to set the wallpaper on all root windows. BUG=123160 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141777

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M ash/desktop_background/desktop_background_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 1 4 chunks +16 lines, -14 lines 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
8 years, 6 months ago (2012-06-12 21:34:42 UTC) #1
Daniel Erat
lgtm http://codereview.chromium.org/10545142/diff/1/ash/desktop_background/desktop_background_controller.cc File ash/desktop_background/desktop_background_controller.cc (right): http://codereview.chromium.org/10545142/diff/1/ash/desktop_background/desktop_background_controller.cc#newcode165 ash/desktop_background/desktop_background_controller.cc:165: if(wo->wallpaper()) { nit: add missing space after 'if'
8 years, 6 months ago (2012-06-12 21:42:22 UTC) #2
oshima
http://codereview.chromium.org/10545142/diff/1/ash/desktop_background/desktop_background_controller.cc File ash/desktop_background/desktop_background_controller.cc (right): http://codereview.chromium.org/10545142/diff/1/ash/desktop_background/desktop_background_controller.cc#newcode165 ash/desktop_background/desktop_background_controller.cc:165: if(wo->wallpaper()) { On 2012/06/12 21:42:22, Daniel Erat wrote: > ...
8 years, 6 months ago (2012-06-12 21:51:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10545142/4001
8 years, 6 months ago (2012-06-12 21:52:55 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 23:06:42 UTC) #5
Change committed as 141777

Powered by Google App Engine
This is Rietveld 408576698