Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 10545140: aura: Window should notify WindowDelegate of bounds changed if Layer cannot. (Closed)

Created:
8 years, 6 months ago by varunjain
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Window should notify WindowDelegate of bounds changed if Layer cannot. BUG=131611 TEST=added new test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141795

Patch Set 1 #

Total comments: 2

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M ui/aura/window.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 1 3 chunks +19 lines, -7 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
varunjain
8 years, 6 months ago (2012-06-12 18:50:57 UTC) #1
sky
LGTM https://chromiumcodereview.appspot.com/10545140/diff/1/ui/aura/window.cc File ui/aura/window.cc (right): https://chromiumcodereview.appspot.com/10545140/diff/1/ui/aura/window.cc#newcode607 ui/aura/window.cc:607: // changed notification from the layer. We must ...
8 years, 6 months ago (2012-06-12 21:19:39 UTC) #2
varunjain
https://chromiumcodereview.appspot.com/10545140/diff/1/ui/aura/window.cc File ui/aura/window.cc (right): https://chromiumcodereview.appspot.com/10545140/diff/1/ui/aura/window.cc#newcode607 ui/aura/window.cc:607: // changed notification from the layer. We must notify ...
8 years, 6 months ago (2012-06-12 21:28:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10545140/1004
8 years, 6 months ago (2012-06-12 21:28:46 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 00:04:39 UTC) #5
Change committed as 141795

Powered by Google App Engine
This is Rietveld 408576698