Issue 10545133: Support the ModemManager1 interfaces for SMS messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545133: Support the ModemManager1 interfaces for SMS messages (Closed)

Created:
8 years, 6 months ago by Ben Chan

Modified:
8 years, 6 months ago

Reviewers:
hashimoto1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, Jason Glasgow

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Support the ModemManager1 interfaces for SMS messages Add dbus support the org.freedesktop.ModemManager1.SMS and org.freedesktop.ModemManager1.Modem.Messaging interfaces. This CL is authored by Jason Glasgow <jglasgow@chromium.org>; and reviewed on https://chromiumcodereview.appspot.com/10533006 BUG=chromium-os:28421 TEST=chromeos_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141634

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+692 lines, -180 lines)			Patch
M	chromeos/chromeos.gyp	View	4 chunks	+9 lines, -0 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chromeos/dbus/dbus_thread_manager.cc	View	6 chunks	+21 lines, -1 line	0 comments	Download
M	chromeos/dbus/flimflam_device_client.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_manager_client.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chromeos/dbus/gsm_sms_client.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chromeos/dbus/gsm_sms_client.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chromeos/dbus/gsm_sms_client_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager.h	View	4 chunks	+12 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_gsm_sms_client.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chromeos/dbus/mock_modem_messaging_client.h	View	2 chunks	+10 lines, -14 lines	0 comments	Download
A	chromeos/dbus/mock_modem_messaging_client.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	chromeos/dbus/mock_sms_client.h	View	1 chunk	+29 lines, -0 lines	0 comments	Download
A	chromeos/dbus/mock_sms_client.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A +	chromeos/dbus/modem_messaging_client.h	View	2 chunks	+20 lines, -34 lines	0 comments	Download
A	chromeos/dbus/modem_messaging_client.cc	View	1 chunk	+278 lines, -0 lines	0 comments	Download
A +	chromeos/dbus/modem_messaging_client_unittest.cc	View	14 chunks	+49 lines, -125 lines	0 comments	Download
A	chromeos/dbus/sms_client.h	View	1 chunk	+57 lines, -0 lines	0 comments	Download
A	chromeos/dbus/sms_client.cc	View	1 chunk	+130 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 6 months ago (2012-06-12 08:53:12 UTC) #2

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benchan@chromium.org/10545133/1

Expand Messages | Collapse Messages