Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10545128: Unrevert r141537: Add extensions::StateStore and use that instead of (Closed)

Created:
8 years, 6 months ago by Matt Perry
Modified:
8 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, erikwright (departed), Aaron Boodman, mihaip-chromium-reviews_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Unrevert r141537: Add extensions::StateStore and use that instead of ExtensionPrefs for persisting alarm state to disk. More to come: - context menus - omnibox - declarative webRequest TBR=brettw BUG=123366 TEST=extension alarms are still remembered after chrome restart Change since last time: Fall back to a FailingValueStore if ValueStoreFrontend can't open the database. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141780

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix.crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -516 lines) Patch
M base/value_conversions.h View 4 chunks +6 lines, -2 lines 0 comments Download
M base/value_conversions.cc View 2 chunks +20 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.h View 4 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 11 chunks +76 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.cc View 4 chunks +0 lines, -43 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 5 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/extensions/settings/settings_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_quota_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/settings/settings_sync_unittest.cc View 1 9 chunks +13 lines, -19 lines 0 comments Download
A chrome/browser/extensions/state_store.h View 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/browser/extensions/state_store.cc View 1 chunk +75 lines, -0 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 chunk +4 lines, -0 lines 0 comments Download
D chrome/browser/value_store/caching_value_store.h View 1 1 chunk +0 lines, -74 lines 0 comments Download
D chrome/browser/value_store/caching_value_store.cc View 1 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/value_store/caching_value_store_unittest.cc View 1 1 chunk +0 lines, -113 lines 0 comments Download
M chrome/browser/value_store/failing_value_store.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/value_store/failing_value_store.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/value_store/testing_value_store.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/value_store/testing_value_store.cc View 1 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/value_store/testing_value_store_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/value_store/value_store_frontend.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/value_store/value_store_frontend.cc View 1 1 chunk +114 lines, -0 lines 0 comments Download
A + chrome/browser/value_store/value_store_frontend_unittest.cc View 1 4 chunks +32 lines, -29 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Matt Perry
8 years, 6 months ago (2012-06-12 00:15:14 UTC) #1
Matt Perry
http://codereview.chromium.org/10545128/diff/1/chrome/browser/value_store/value_store_frontend.cc File chrome/browser/value_store/value_store_frontend.cc (right): http://codereview.chromium.org/10545128/diff/1/chrome/browser/value_store/value_store_frontend.cc#newcode66 chrome/browser/value_store/value_store_frontend.cc:66: storage_ = new FailingValueStore(); This is the main difference. ...
8 years, 6 months ago (2012-06-12 00:15:56 UTC) #2
Yoyo Zhou
8 years, 6 months ago (2012-06-12 00:18:14 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698