Turn on git diff copy detection for git-cl upload.

Turn on git diff copy detection for git-cl upload.

Enable copy detection for git-cl upload.  This makes
it possible to copy a directory containing many files,
add+commit the new path, and then upload a patch to
Rietveld that shows the files were copied.

In my tests, -C -C was needed to pick up a basic
file copy.  -C was not enough.  I'm not sure why
exactly.  The output generated in the diff looks
like:

  sh$ git diff -C -C HEAD~1..HEAD
  diff --git a/slave/Makefile b/slave2/Makefile
  similarity index 100%
  copy from slave/Makefile
  copy to slave2/Makefile
  ...

(This change requires r141676 /
https://chromiumcodereview.appspot.com/10543116/ which
updates upload.py to use --find-copies-harder.)

R=maruel@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141689

[M-A Ruel, 2012-06-11 00:01:59]

https://chromiumcodereview.appspot.com/10545107/diff/1/third_party/upload.py
File third_party/upload.py (right):

https://chromiumcodereview.appspot.com/10545107/diff/1/third_party/upload.py#...
third_party/upload.py:1309: diff += RunShell(cmd + ["-C", "-C",
"--diff-filter=ACMRT"] + extra_args, env=env,
This needs to happen upstream first.

[cmp, 2012-06-12 17:51:45]

patch updated, ptal

https://chromiumcodereview.appspot.com/10545107/diff/4001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/10545107/diff/4001/git_cl.py#newcode1131
git_cl.py:1131: ['git', 'diff', '--no-ext-diff', '--stat', '-C', '-C'] + args,
env=env)
I assumed you wanted to keep using -C -C here.  LMK if you want me to go back to
--find-copies-harder, though, since that's what upload.py ended up using.

[M-A Ruel, 2012-06-12 18:07:02]

lgtm

https://chromiumcodereview.appspot.com/10545107/diff/4001/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/10545107/diff/4001/git_cl.py#newcode1131
git_cl.py:1131: ['git', 'diff', '--no-ext-diff', '--stat', '-C', '-C'] + args,
env=env)
On 2012/06/12 17:51:45, cmp wrote:
> I assumed you wanted to keep using -C -C here.  LMK if you want me to go back
to
> --find-copies-harder, though, since that's what upload.py ended up using.

You can use --find-copies-harder. :)

[cmp, 2012-06-12 18:12:25]

updated to use --find-copies-harder

[commit-bot: I haz the power, 2012-06-12 18:12:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cmp@chromium.org/10545107/9001

[commit-bot: I haz the power, 2012-06-12 18:20:14]

Change committed as 141689