Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 10545085: Enable --enable-nacl-debug switch on Linux. (Closed)

Created:
8 years, 6 months ago by halyavin
Modified:
8 years, 6 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Enable --enable-nacl-debug switch on Linux. Remove old code that uses command-line passed to NaCl loader to find this switch. BUG=131381 TEST= manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/nacl_cmd_line.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/nacl_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/nacl_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/nacl/nacl_listener.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/nacl/nacl_listener.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/nacl/nacl_main.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
halyavin
8 years, 6 months ago (2012-06-08 11:25:08 UTC) #1
Mark Seaborn
LGTM, thanks!
8 years, 6 months ago (2012-06-08 18:18:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/halyavin@google.com/10545085/1
8 years, 6 months ago (2012-06-08 18:35:09 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 20:06:24 UTC) #4
Change committed as 141267

Powered by Google App Engine
This is Rietveld 408576698