Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 10545084: Move chromeos::GDataFileSystem::GetCacheDirectoryPath and GetCacheFilePath implementation to GDataC… (Closed)

Created:
8 years, 6 months ago by hashimoto
Modified:
8 years, 6 months ago
Reviewers:
achuithb, satorux1
CC:
chromium-reviews, achuith+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Move chromeos::GDataFileSystem::GetCacheDirectoryPath and GetCacheFilePath implementation to GDataCache This is a part of an effort to move cache related code from GDataFileSystem to GDataCache. GDataFileSystem::GetCacheDirectoryPath and GetCacheFilePath are still provided to serve a number of existing users, this is a temporary solution. cache_paths() and kMountedArchiveFileExtension are exposed as a temporary solution. Tests for these methods are not moved from GDataFileSystemTest in this change, they will be removed and reimplemented once we finish moving other methods and get ready to do more comprehensive test in GDataCacheTest. BUG=131756 TEST=unit_tests --gtest_filter="GData*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141223

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -222 lines) Patch
M chrome/browser/chromeos/gdata/gdata_cache.h View 4 chunks +33 lines, -5 lines 1 comment Download
M chrome/browser/chromeos/gdata/gdata_cache.cc View 5 chunks +67 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_cache_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.h View 5 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system.cc View 24 chunks +118 lines, -154 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_file_system_unittest.cc View 19 chunks +31 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_util.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/gdata/mock_gdata_file_system.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
8 years, 6 months ago (2012-06-08 11:05:28 UTC) #1
satorux1
https://chromiumcodereview.appspot.com/10545084/diff/1/chrome/browser/chromeos/gdata/gdata_cache.h File chrome/browser/chromeos/gdata/gdata_cache.h (right): https://chromiumcodereview.appspot.com/10545084/diff/1/chrome/browser/chromeos/gdata/gdata_cache.h#newcode122 chrome/browser/chromeos/gdata/gdata_cache.h:122: FilePath GetCacheDirectoryPath(CacheSubDirectoryType sub_dir_type) const; The class used to be ...
8 years, 6 months ago (2012-06-08 15:10:54 UTC) #2
satorux1
LGTM
8 years, 6 months ago (2012-06-08 15:11:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10545084/1
8 years, 6 months ago (2012-06-08 15:12:33 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 17:25:53 UTC) #5
Change committed as 141223

Powered by Google App Engine
This is Rietveld 408576698