Issue 10545082: Clean up some minor stuff in test expectation files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545082: Clean up some minor stuff in test expectation files (Closed)

Created:
8 years, 6 months ago by Jakob Kummerow

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Clean up some minor stuff in test expectation files Committed: https://code.google.com/p/v8/source/detail?r=11757

Patch Set 1 #

Total comments: 4

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	test/mjsunit/mjsunit.status	View		3 chunks	+4 lines, -4 lines	3 comments	Download
	M	test/mozilla/mozilla.status	View		1 chunk	+5 lines, -5 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. https://chromiumcodereview.appspot.com/10545082/diff/1/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://chromiumcodereview.appspot.com/10545082/diff/1/test/mjsunit/mjsunit.status#newcode31 test/mjsunit/mjsunit.status:31: bugs/*: FAIL Make it explicit that this is ...

8 years, 6 months ago (2012-06-08 09:36:13 UTC) #1

Michael Starzinger

8 years, 6 months ago (2012-06-11 09:46:05 UTC) #2

LGTM (if one comment is addressed).

https://chromiumcodereview.appspot.com/10545082/diff/1/test/mjsunit/mjsunit.s...
File test/mjsunit/mjsunit.status (right):

https://chromiumcodereview.appspot.com/10545082/diff/1/test/mjsunit/mjsunit.s...
test/mjsunit/mjsunit.status:31: bugs/*: FAIL
On 2012/06/08 09:36:13, Jakob wrote:
> Make it explicit that this is a wildcard matching rule.

Same applies to message.status, please change it there as well.

Expand Messages | Collapse Messages