Create symlinks to nacl resources when running tests on chromeos

Create symlinks to nacl resources when running tests on chromeos

These will be used by browser_tests on chromeos.

BUG=
TEST=
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141199

[Brad Chen, 2012-06-07 22:35:25]

LGTM. Please consider the nits below.

http://codereview.chromium.org/10545071/diff/1/chrome/test/chromeos/autotest/...
File
chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh
(right):

http://codereview.chromium.org/10545071/diff/1/chrome/test/chromeos/autotest/...
chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh:20:
# Nacl symlinks.
Nits: We usually use "NaCl". Might be worth stating explicitly what is being
linked, the nacl_helper, nacl_helper_bootstrap, for NaCl startup, and the Pepper
plugin that implements NaCl for Chrome.

I'm also assuming the bit-ness of /opt/google/chrome is always the same as what
you are testing. The NaCl files can differ for 32- vs 64-bit.

[Nirnimesh, 2012-06-08 01:49:54]

http://codereview.chromium.org/10545071/diff/1/chrome/test/chromeos/autotest/...
File
chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh
(right):

http://codereview.chromium.org/10545071/diff/1/chrome/test/chromeos/autotest/...
chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh:20:
# Nacl symlinks.
On 2012/06/07 22:35:25, Brad Chen wrote:
> Nits: We usually use "NaCl". Might be worth stating explicitly what is being
> linked, the nacl_helper, nacl_helper_bootstrap, for NaCl startup, and the
Pepper
> plugin that implements NaCl for Chrome.

I've changed it to explicitly list down nacl_heper and nacl_helper_bootstrap


> 
> I'm also assuming the bit-ness of /opt/google/chrome is always the same as
what
> you are testing. The NaCl files can differ for 32- vs 64-bit.

It's correct for nacl_helper and nacl_helper_bootstrap

/opt/google/chrome has both nacl_irt_x86_32.nexe and nacl_irt_x86_64.nexe
Should there be only one?

[Brad Chen, 2012-06-08 03:22:48]

http://codereview.chromium.org/10545071/diff/1/chrome/test/chromeos/autotest/...
File
chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh
(right):

http://codereview.chromium.org/10545071/diff/1/chrome/test/chromeos/autotest/...
chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh:20:
# Nacl symlinks.
No there are 32 and 64-bit versions. Linking both is fine. Perhaps we shouldn't
be shipping the 64-bit version to 32-bit systems and visa versa; opportunity for
build refinement.

On 2012/06/08 01:49:54, Nirnimesh wrote:
> On 2012/06/07 22:35:25, Brad Chen wrote:
> > Nits: We usually use "NaCl". Might be worth stating explicitly what is being
> > linked, the nacl_helper, nacl_helper_bootstrap, for NaCl startup, and the
> Pepper
> > plugin that implements NaCl for Chrome.
> 
> I've changed it to explicitly list down nacl_heper and nacl_helper_bootstrap
> 
> 
> > 
> > I'm also assuming the bit-ness of /opt/google/chrome is always the same as
> what
> > you are testing. The NaCl files can differ for 32- vs 64-bit.
> 
> It's correct for nacl_helper and nacl_helper_bootstrap
> 
> /opt/google/chrome has both nacl_irt_x86_32.nexe and nacl_irt_x86_64.nexe
> Should there be only one?

[commit-bot: I haz the power, 2012-06-08 11:39:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nirnimesh@chromium.org/10545071/4001

[commit-bot: I haz the power, 2012-06-08 11:53:22]

Change committed as 141199