Issue 10545070: Make platform app restrictions more robust.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545070: Make platform app restrictions more robust. (Closed)

Created:
8 years, 6 months ago by Evan Stade

Modified:
8 years, 6 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jochen+watch-content_chromium.org, jeremya+watch_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make platform app restrictions more robust. Most of these are disabled in C++ anyway, but this layer of protection was leaky. It allowed, for example, Window.prototype.find.apply(window, ['string']); BUG=130835 TEST=PlatformAppBrowserTest.Restrictions Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141156

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remove debugging code #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -30 lines)			Patch
	M	chrome/renderer/resources/extensions/platform_app.js	View	1	3 chunks	+14 lines, -13 lines	0 comments	Download
	M	chrome/test/data/extensions/platform_apps/restrictions/test.js	View	1	3 chunks	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

(as an aside, I'm not sure why find is even disabled --- it doesn't actually ...

8 years, 6 months ago (2012-06-07 21:35:17 UTC) #1

LGTM

Expand Messages | Collapse Messages