Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 10545064: TabContentsWrapper -> TabContents, part 11. (Closed)

Created:
8 years, 6 months ago by Avi (use Gerrit)
Modified:
8 years, 6 months ago
CC:
chromium-reviews, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

TabContentsWrapper -> TabContents, part 11. Downloads. BUG=131026 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -49 lines) Patch
M chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/download/download_danger_prompt.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/download/download_danger_prompt.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/download/download_danger_prompt_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_request_limiter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 5 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
8 years, 6 months ago (2012-06-07 21:31:41 UTC) #1
Randy Smith (Not in Mondays)
Avi, one question: Is the GetSelectedWebContents -> GetActiveWebContents just a rename? Or is there a ...
8 years, 6 months ago (2012-06-08 16:00:49 UTC) #2
Avi (use Gerrit)
It's just a rename. It was a TODO to rename "GetSelectedWebContents" to "GetActiveWebContents" ever since ...
8 years, 6 months ago (2012-06-08 16:05:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10545064/1
8 years, 6 months ago (2012-06-08 16:05:31 UTC) #4
commit-bot: I haz the power
Try job failure for 10545064-1 on linux_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=30718 Step "update" is always ...
8 years, 6 months ago (2012-06-08 16:11:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10545064/1
8 years, 6 months ago (2012-06-08 16:20:44 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 17:56:08 UTC) #7
Change committed as 141235

Powered by Google App Engine
This is Rietveld 408576698