Issue 10545062: NaCl: Fix a file to compile with -Wundef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10545062: NaCl: Fix a file to compile with -Wundef (Closed)

Created:
8 years, 6 months ago by Mark Seaborn

Modified:
8 years, 6 months ago

Reviewers:
Nick Bray (chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl: Fix a file to compile with -Wundef -Wundef warns about "#if FOO" when FOO is undefined. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2787 TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141080

Patch Set 1 #

Patch Set 2 : Copyright #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	ppapi/native_client/tests/ppapi_geturl/url_load_request.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nick Bray (chromium)

8 years, 6 months ago (2012-06-07 19:38:16 UTC) #2

LGTM, but that may not be enough for the CQ.

Expand Messages | Collapse Messages