Issue 10545058: Add UIControlsAsh that works with multiple root windows

Issue 10545058: Add UIControlsAsh that works with multiple root windows (Closed)

Created:
8 years, 6 months ago by oshima

Modified:
8 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add UIControlsAsh that works with multiple root windows I'll add test for this when I add multiple root window support, which should be soon. BUG=123160 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141170

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : fix nit #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -1 line)			Patch
M	ash/ash.gyp	View	2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/shell.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	ash/shell_factory.h	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
A	ash/ui_controls_ash.cc	View	1 2	1 chunk	+131 lines, -0 lines	0 comments	Download
M	ash/wm/window_properties.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	ash/wm/window_properties.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10545058/diff/6003/ash/shell_factory.h File ash/shell_factory.h (right): http://codereview.chromium.org/10545058/diff/6003/ash/shell_factory.h#newcode29 ash/shell_factory.h:29: nit: remove this line.

8 years, 6 months ago (2012-06-07 22:18:05 UTC) #2

oshima

http://codereview.chromium.org/10545058/diff/6003/ash/shell_factory.h File ash/shell_factory.h (right): http://codereview.chromium.org/10545058/diff/6003/ash/shell_factory.h#newcode29 ash/shell_factory.h:29: On 2012/06/07 22:18:05, sky wrote: > nit: remove this ...

8 years, 6 months ago (2012-06-08 00:24:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10545058/32

8 years, 6 months ago (2012-06-08 02:57:27 UTC) #4

Change committed as 141170

Expand Messages | Collapse Messages