mac: Use NSWidth() and friends in a few more places.

mac: Use NSWidth() and friends in a few more places.

No intended behavior change.

BUG=none
TEST=none
TBR=owners

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141084

[Nico, 2012-06-07 05:34:06]

I find this a bit easier to read. I noticed it in to files and then kind of got
carried away for a while.

[Robert Sesek, 2012-06-07 16:52:38]

I agree these are easier to read. Maybe it's because I'm early, but I'm not sure
some of the NSMaxY changes are correct.

Also, should we update the Cocoa conventions document on dev.chromium?

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:272:
bounds.set_y(NSHeight([screen frame]) - NSMaxY(frame));
Is NSMaxY correct here? (that's origin.y + size.height)

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/browser_window_controller.mm:769:
(NSWidth(curScrIntersectCurFr) * NSHeight(curScrIntersectCurFr) - 1.0))
nit: This if should have braces because the condition spans multiple lines.

[Nico, 2012-06-07 17:40:23]

Thanks!

It's probably good enough to rely on osmosis; I wouldn't update the style guide.

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:272:
bounds.set_y(NSHeight([screen frame]) - NSMaxY(frame));
On 2012/06/07 16:52:38, rsesek wrote:
> Is NSMaxY correct here? (that's origin.y + size.height)

- frame.origin.y - frame.size.height ==
- (frame.origin.y + frame.size.height) ==
-NSMaxY(frame)

…should be correct?

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/browser_window_controller.mm:769:
(NSWidth(curScrIntersectCurFr) * NSHeight(curScrIntersectCurFr) - 1.0))
On 2012/06/07 16:52:38, rsesek wrote:
> nit: This if should have braces because the condition spans multiple lines.

Done.

[Robert Sesek, 2012-06-07 18:37:20]

LGTM

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://chromiumcodereview.appspot.com/10545050/diff/2001/chrome/browser/ui/c...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:272:
bounds.set_y(NSHeight([screen frame]) - NSMaxY(frame));
On 2012/06/07 17:40:23, Nico wrote:
> On 2012/06/07 16:52:38, rsesek wrote:
> > Is NSMaxY correct here? (that's origin.y + size.height)
> 
> - frame.origin.y - frame.size.height ==
> - (frame.origin.y + frame.size.height) ==
> -NSMaxY(frame)
> 
> …should be correct?

You're right. Lost track of the negative when going through this in my head.

[commit-bot: I haz the power, 2012-06-07 18:37:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10545050/1016

[commit-bot: I haz the power, 2012-06-07 18:37:50]

Presubmit check for 10545050-1016 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    webkit
    ui/gfx

Presubmit checks took 2.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-06-07 21:33:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10545050/1016