Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 10545041: Merge 118096 (Closed)

Created:
8 years, 6 months ago by Chris Evans
Modified:
8 years, 6 months ago
Reviewers:
tkent, cevans
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/WebCore/dom/ContainerNodeAlgorithms.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Chris Evans
8 years, 6 months ago (2012-06-06 21:48:37 UTC) #1
tkent
No, we shouldn't merge this. It made a lot of regressions. We should merge http://trac.webkit.org/changeset/118725 ...
8 years, 6 months ago (2012-06-06 22:19:44 UTC) #2
cevans
On Wed, Jun 6, 2012 at 3:19 PM, <tkent@chromium.org> wrote: > No, we shouldn't merge ...
8 years, 6 months ago (2012-06-06 22:29:28 UTC) #3
cevans
Adding Abhishek to the discussion. On Wed, Jun 6, 2012 at 3:29 PM, Chris Evans ...
8 years, 6 months ago (2012-06-06 22:48:35 UTC) #4
tkent
I should have made a comment about it in crbug.com/128157. I'm sorry for it. http://trac.webkit.org/changeset/118096 ...
8 years, 6 months ago (2012-06-06 23:20:09 UTC) #5
cevans
8 years, 6 months ago (2012-06-07 00:57:54 UTC) #6
Reverted at r119656, thanks

On Wed, Jun 6, 2012 at 4:20 PM, <tkent@chromium.org> wrote:

> I should have made a comment about it in crbug.com/128157.  I'm sorry for
> it.
>
>
http://trac.webkit.org/**changeset/118096<http://trac.webkit.org/changeset/11...
rolled out by
>
http://trac.webkit.org/**changeset/118203<http://trac.webkit.org/changeset/11....
>
http://trac.webkit.org/**changeset/118725<http://trac.webkit.org/changeset/11...
> doesn't depend on r118096.  So we should revert this merge.
>
>
>
https://chromiumcodereview.**appspot.com/10545041/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698