Aura/GTK integration: Create a small stub library that can talk to GTK.

Aura/GTK integration: Create a small stub library that can talk to GTK.

This makes a ui::LinuxUI interface, which needs to be in ui/base/ since we'll
be integrating it with ui::NativeTheme and ui/views/. We also add a libgtk2ui
shared library, which has a single exported method which creates an LinuxUI
object that is essentially the old GtkThemeService. The intent is that this
library will be the only part of chrome that can link with GTK in aura land.

Current results are very rough; only some theme images are being injected
properly and there's a bunch of entirely new theme integration that will have
to be written to interface with views. Still, this is more than enough to
demonstrate intent to continue to support gtk2.

BUG=130810
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140922

[Elliot Glaysher, 2012-06-06 20:44:50]

First of what will be many patches to port GTK themeing to the aura build.

[sky, 2012-06-06 21:04:07]

LGTM

http://codereview.chromium.org/10545037/diff/10021/chrome/browser/ui/aura/chr...
File chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc (right):

http://codereview.chromium.org/10545037/diff/10021/chrome/browser/ui/aura/chr...
chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc:18: #if
defined(OS_LINUX)
Can you move this into its own block after the ash one, eg:

#if !defined(USE_ASH) && defined(OS_LINUX)

http://codereview.chromium.org/10545037/diff/10021/ui/base/linux_ui.cc
File ui/base/linux_ui.cc (right):

http://codereview.chromium.org/10545037/diff/10021/ui/base/linux_ui.cc#newcode9
ui/base/linux_ui.cc:9: ui::LinuxUI* g_linux_ui = 0;
NULL

http://codereview.chromium.org/10545037/diff/10021/ui/base/linux_ui.cc#newcode16
ui/base/linux_ui.cc:16: delete(g_linux_ui);
no ()

http://codereview.chromium.org/10545037/diff/10021/ui/base/linux_ui.h
File ui/base/linux_ui.h (right):

http://codereview.chromium.org/10545037/diff/10021/ui/base/linux_ui.h#newcode45
ui/base/linux_ui.h:45: virtual ~LinuxUI() {}
nit: destructors before all other methods (including statics).

[commit-bot: I haz the power, 2012-06-06 21:23:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10545037/11022

[commit-bot: I haz the power, 2012-06-06 21:28:41]

Try job failure for 10545037-11022 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-06-07 00:08:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10545037/11022

[commit-bot: I haz the power, 2012-06-07 01:25:54]

Change committed as 140922

[tfarina, 2012-06-07 17:02:05]

http://codereview.chromium.org/10545037/diff/11022/chrome/browser/ui/libgtk2u...
File chrome/browser/ui/libgtk2ui/gtk2_ui.h (right):

http://codereview.chromium.org/10545037/diff/11022/chrome/browser/ui/libgtk2u...
chrome/browser/ui/libgtk2ui/gtk2_ui.h:37: // LinuxShell:
nit: s/LinuxShell/ui::LinuxUI

http://codereview.chromium.org/10545037/diff/11022/chrome/browser/ui/libgtk2u...
File chrome/browser/ui/libgtk2ui/libgtk2ui.gyp (right):

http://codereview.chromium.org/10545037/diff/11022/chrome/browser/ui/libgtk2u...
chrome/browser/ui/libgtk2ui/libgtk2ui.gyp:41: 'owned_widget_gtk2.cc',
nit: list libgtk2ui_export.h here?

http://codereview.chromium.org/10545037/diff/11022/chrome/browser/ui/libgtk2u...
File chrome/browser/ui/libgtk2ui/libgtk2ui_export.h (right):

http://codereview.chromium.org/10545037/diff/11022/chrome/browser/ui/libgtk2u...
chrome/browser/ui/libgtk2ui/libgtk2ui_export.h:1: // Copyright (c) 2011 The
Chromium Authors. All rights reserved.
nit: s/2011/2012

http://codereview.chromium.org/10545037/diff/11022/chrome/browser/ui/libgtk2u...
chrome/browser/ui/libgtk2ui/libgtk2ui_export.h:9: // Defines LIBGTK2UI_EXPORT so
that functionality implemented by the aura module
nit: s/aura/libgtk2ui

http://codereview.chromium.org/10545037/diff/11022/ui/base/linux_ui.h
File ui/base/linux_ui.h (right):

http://codereview.chromium.org/10545037/diff/11022/ui/base/linux_ui.h#newcode25
ui/base/linux_ui.h:25: // minimum) GTK2 and GTK3. LinuxShell::instance() should
actually be a very
nit: s/LinuxShell/LinuxUI