Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10545033: Removed the PolicyDefinitionList from the ConfigurationPolicyProvider interface. (Closed)

Created:
8 years, 6 months ago by Joao da Silva
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Removed the PolicyDefinitionList from the ConfigurationPolicyProvider interface. Also deleted some files left behind when the linux and mac providers were refactored. BUG=130918 TEST=nothing breaks Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141008

Patch Set 1 #

Patch Set 2 : Fix win build #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -972 lines) Patch
M chrome/browser/policy/async_policy_provider.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/async_policy_provider.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/policy/async_policy_provider_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/policy/cloud_policy_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/cloud_policy_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/policy/cloud_policy_provider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/config_dir_policy_loader.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/policy/config_dir_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/policy/config_dir_policy_provider.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D chrome/browser/policy/config_dir_policy_provider_unittest.cc View 1 chunk +0 lines, -248 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider.h View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/policy/configuration_policy_provider.cc View 1 chunk +1 line, -4 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider_mac.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D chrome/browser/policy/configuration_policy_provider_mac_unittest.cc View 1 chunk +0 lines, -316 lines 0 comments Download
M chrome/browser/policy/mock_configuration_policy_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/policy/policy_loader_mac_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_loader_win_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/proxy_policy_provider.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/policy/user_cloud_policy_manager_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
Here's another cleanup. Please review, thanks!
8 years, 6 months ago (2012-06-06 15:43:05 UTC) #1
Mattias Nissler (ping if slow)
LGTM in general, however, you seem to have parts of the removal CL in this ...
8 years, 6 months ago (2012-06-06 17:27:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10545033/6003
8 years, 6 months ago (2012-06-07 10:25:59 UTC) #3
commit-bot: I haz the power
Try job failure for 10545033-6003 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=14697 Step "update" is always ...
8 years, 6 months ago (2012-06-07 10:31:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10545033/6003
8 years, 6 months ago (2012-06-07 11:44:18 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-07 14:11:03 UTC) #6
Change committed as 141008

Powered by Google App Engine
This is Rietveld 408576698