Issue 10544205: Fix optimized code caching in FastNewClosureStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10544205: Fix optimized code caching in FastNewClosureStub. (Closed)

Created:
8 years, 6 months ago by Michael Starzinger

Modified:
8 years, 6 months ago

Reviewers:
Florian Schneider, ulan

CC:
v8-dev, fschneider, palfia

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix optimized code caching in FastNewClosureStub. This fixes a corner-case on ARM and MIPS where optimized code was not shared immediately across closures when a function was used in several global contexts at once. R=ulan@chromium.org TEST=cctest/test-compiler/OptimizedCodeSharing Committed: https://code.google.com/p/v8/source/detail?r=11850

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/cctest/test-compiler.cc	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Good catch! Thanks for fixing this

Expand Messages | Collapse Messages