Defer creating Handles for HConstants to the code generation phase.

src/hydrogen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 269 matching lines @@
   bool CheckConstPhiUses();
 
   void CollectPhis();
 
   Handle<Code> Compile();
 
   void set_undefined_constant(HConstant* constant) {
     undefined_constant_.set(constant);
   }
   HConstant* GetConstantUndefined() const { return undefined_constant_.get(); }
+  HConstant* GetConstantInt32(SetOncePointer<HConstant>* pointer,

[Michael Starzinger, 2012/07/10 12:05:51]

This should be moved into the private section right after GetConstant().

[sanjoy, 2012/07/10 19:25:17]

Done.

+                              int32_t integer_value);
   HConstant* GetConstant1();
   HConstant* GetConstantMinus1();
   HConstant* GetConstantTrue();
   HConstant* GetConstantFalse();
   HConstant* GetConstantHole();
 
   HBasicBlock* CreateBasicBlock();
   HArgumentsObject* GetArgumentsObject() const {
     return arguments_object_.get();
   }
@@ skipping 888 matching lines @@
   HGraph* graph_;
   HBasicBlock* current_block_;
 
   int inlined_count_;
   ZoneList<Handle<Object> > globals_;
 
   Zone* zone_;
 
   bool inline_bailout_;
 
+  HConstant* constant_undefined_;

[Michael Starzinger, 2012/07/10 12:05:51]

I don't think this change is actually needed.

[sanjoy, 2012/07/10 19:25:17]

Done.

+  HConstant* constant_null_;
+
   friend class FunctionState;  // Pushes and pops the state stack.
   friend class AstContext;  // Pushes and pops the AST context stack.
 
   DISALLOW_COPY_AND_ASSIGN(HGraphBuilder);
 };
 
 
 Zone* AstContext::zone() const { return owner_->zone(); }
 
 
@@ skipping 232 matching lines @@
   const char* filename_;
   HeapStringAllocator string_allocator_;
   StringStream trace_;
   int indent_;
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_H_