Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: dart/lib/compiler/implementation/scanner/partial_parser.dart

Issue 10544173: Update partial parser and scanner to be able to skip expressions like "new Map<S, T>()". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/lib/compiler/implementation/scanner/partial_parser.dart
diff --git a/dart/lib/compiler/implementation/scanner/partial_parser.dart b/dart/lib/compiler/implementation/scanner/partial_parser.dart
index 1e792d0410d289bdf483dfab28e04626e6489b8f..b805c92f65fbbe8d1bf9075bbc645100de49adcd 100644
--- a/dart/lib/compiler/implementation/scanner/partial_parser.dart
+++ b/dart/lib/compiler/implementation/scanner/partial_parser.dart
@@ -56,7 +56,7 @@ class PartialParser extends Parser {
}
if (!mayParseFunctionExpressions && value === '{')
Lasse Reichstein Nielsen 2012/06/15 11:51:13 While you are here, please put curly braces around
ahe 2012/06/15 13:12:34 No need. It fits on the previous line.
Lasse Reichstein Nielsen 2012/06/15 13:59:14 I generally prefer to put return statements on a l
ahe 2012/06/19 11:02:42 OK. We have used the "bailout" return can go on th
return token;
- if ((value !== '<') && (token is BeginGroupToken)) {
+ if (token is BeginGroupToken) {
BeginGroupToken begin = token;
token = (begin.endGroup !== null) ? begin.endGroup : token;
}

Powered by Google App Engine
This is Rietveld 408576698