Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 10544156: Adds warning when a named argument is specified, but a positional argument is missing (Closed)

Created:
8 years, 6 months ago by zundel
Modified:
8 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, scheglov
Visibility:
Public.

Description

Adds warning when a named argument is specified, but a positional argument is missing http://code.google.com/p/dart/issues/detail?id=1941 Committed: https://code.google.com/p/dart/source/detail?r=8677

Patch Set 1 : # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -16 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 3 chunks +4 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 1 chunk +19 lines, -11 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 2 chunks +12 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 6 months ago (2012-06-14 11:57:40 UTC) #1
Brian Wilkerson
8 years, 6 months ago (2012-06-14 15:14:17 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698