Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/theme/README

Issue 10544145: OWNERS file for chrome/apps/theme (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add ui/resources Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/theme/OWNERS ('k') | ui/resources/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/theme/README
diff --git a/chrome/app/theme/README b/chrome/app/theme/README
new file mode 100644
index 0000000000000000000000000000000000000000..7475eab32ede1e7214ea3d8103472e98bc7205df
--- /dev/null
+++ b/chrome/app/theme/README
@@ -0,0 +1,17 @@
+When adding a new icon please follow these two steps:
+
+Step 1. Run pngcrush on all new icons. For example:
+ mkdir crushed
+ pngcrush -d crushed -brute -reduce new/*.png
+
+Step 2. While adding an icon to one of the following files:
+ theme_resources_standard.grd
+ theme_resources_2x.grd
+ theme_resources_touch_1x.grd
+ theme_resources_touch_2x.grd
+make sure to add the same icon to all the other .grd files.
+Verify that you did this correctly by doing a diff of the generated header
+files. For example:
+ diff Debug/gen/chrome/grit/theme_resources_standard.h \
+ Debug/gen/chrome/grit/theme_resources_2x.h
+should be empty.
« no previous file with comments | « chrome/app/theme/OWNERS ('k') | ui/resources/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698