chrome/app/theme/README - Issue 10544145: OWNERS file for chrome/apps/theme

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/theme/README

Issue 10544145: OWNERS file for chrome/apps/theme (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add ui/resources Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 When adding a new icon please follow these two steps:

	2

	3 Step 1. Run pngcrush on all new icons. For example:

	4 mkdir crushed

	5 pngcrush -d crushed -brute -reduce new/*.png

	6

	7 Step 2. While adding an icon to one of the following files:

	8 theme_resources_standard.grd

	9 theme_resources_2x.grd

	10 theme_resources_touch_1x.grd

	11 theme_resources_touch_2x.grd

	12 make sure to add the same icon to all the other .grd files.

	13 Verify that you did this correctly by doing a diff of the generated header

	14 files. For example:

	15 diff Debug/gen/chrome/grit/theme_resources_standard.h \

	16 Debug/gen/chrome/grit/theme_resources_2x.h

	17 should be empty.

OLD	NEW

« no previous file with comments | « chrome/app/theme/OWNERS ('k') | ui/resources/OWNERS » ('j') | no next file with comments »