Issue 10544143: Browser Plugin: Plumbing to enable tabbing out of a browser tag

Issue 10544143: Browser Plugin: Plumbing to enable tabbing out of a browser tag (Closed)

Created:
8 years, 6 months ago by Fady Samuel

Modified:
8 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit), jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

Browser Plugin: Plumbing to enable tabbing out of a browser tag BUG=none TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142077

Patch Set 2 : Fixed nit #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
M	content/browser/browser_plugin/browser_plugin_host.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_host.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/common/browser_plugin_messages.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin_channel_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/browser_plugin/browser_plugin_channel_manager.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Fady Samuel

Simple patch that enables focusing out of a guest and back into an embedder page.

8 years, 6 months ago (2012-06-13 20:52:00 UTC) #1

jochen (gone - plz use gerrit)

drive-by comments https://chromiumcodereview.appspot.com/10544143/diff/1/content/browser/browser_plugin/browser_plugin_host.h File content/browser/browser_plugin/browser_plugin_host.h (right): https://chromiumcodereview.appspot.com/10544143/diff/1/content/browser/browser_plugin/browser_plugin_host.h#newcode123 content/browser/browser_plugin/browser_plugin_host.h:123: }; shouldn't this class disallow copy and ...

8 years, 6 months ago (2012-06-14 00:00:41 UTC) #2

Fady Samuel

Jochen's comment has been addressed. Committing now. https://chromiumcodereview.appspot.com/10544143/diff/1/content/browser/browser_plugin/browser_plugin_host.h File content/browser/browser_plugin/browser_plugin_host.h (right): https://chromiumcodereview.appspot.com/10544143/diff/1/content/browser/browser_plugin/browser_plugin_host.h#newcode123 content/browser/browser_plugin/browser_plugin_host.h:123: }; On ...

8 years, 6 months ago (2012-06-14 01:40:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10544143/5001

8 years, 6 months ago (2012-06-14 01:41:06 UTC) #5

Change committed as 142077

Expand Messages | Collapse Messages