Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10544140: Sometimes DEPS will not pin a revision for a dependency, but just let it float (Closed)

Created:
8 years, 6 months ago by szager1
Modified:
8 years, 6 months ago
Reviewers:
cmp
CC:
chromium-reviews, cmp+cc_chromium.org
Visibility:
Public.

Description

Sometimes DEPS will not pin a revision for a dependency, but just let it float to ToT. Handle that. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141963

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Minimize work to find remote HEAD for floating dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M deps2git/deps2submodules.py View 1 2 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
szager1
8 years, 6 months ago (2012-06-13 18:04:01 UTC) #1
cmp
lgtm
8 years, 6 months ago (2012-06-13 20:46:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/10544140/3002
8 years, 6 months ago (2012-06-13 20:47:45 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-13 20:48:41 UTC) #4
Change committed as 141963

Powered by Google App Engine
This is Rietveld 408576698