Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 10544136: Automatically run file command on remote connection to the target if NaCl manifest was provided by … (Closed)

Created:
8 years, 6 months ago by halyavin
Modified:
8 years, 6 months ago
Reviewers:
eaeltsin
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@nacl-stub
Visibility:
Public.

Description

Automatically run file command on remote connection to the target if NaCl manifest was provided by nacl-manifest command before that. All information about NaCl program is already in the manifest. So we shouldn't require to enter this information twice. We can't just execute file command whenever user issues nacl-manifest command though since we don't know the program architecture until gdb will connect to debug stub. That's why this should be done the moment we know the program architecture (and file command doesn't fail) but before gdb tries to find symbols in the main program. The only such moment when we can execute our code is about_to_proceed event. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2848 TEST= run chrome with --enable-nacl-debug --nacl-gdb=..., set breakpoints, execute target remote command. R=eaeltsin@google.com Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=183c0d2

Patch Set 1 #

Patch Set 2 : style #

Patch Set 3 : Check r->dirname size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M gdb/nacl-manifest.c View 1 2 6 chunks +52 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
halyavin
8 years, 6 months ago (2012-06-13 14:11:36 UTC) #1
eaeltsin
8 years, 6 months ago (2012-06-13 19:25:22 UTC) #2
lgtm

Not sure I like the way our gdb initializes, but don't want to block browser
integration on this.

We might want to refactor this later. The main problem is that gdb does not know
the architecture before connecting to the target, and after connecting might be
too late for a number of setup hooks.

Powered by Google App Engine
This is Rietveld 408576698