Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 10544135: No longer issue ticks more often when debugger is activated. (Closed)

Created:
8 years, 6 months ago by Yang
Modified:
8 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Remove faster ticks for debug mode. This solves the problem that code runs very slow when the debugger is enabled. BUG=v8:2179 TEST= Committed: https://code.google.com/p/v8/source/detail?r=11802

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
PTAL.
8 years, 6 months ago (2012-06-13 13:34:38 UTC) #1
Jakob Kummerow
LGTM, if there are no test timeouts.
8 years, 6 months ago (2012-06-13 13:39:18 UTC) #2
Yang
On 2012/06/13 13:39:18, Jakob wrote: > LGTM, if there are no test timeouts. Another look ...
8 years, 6 months ago (2012-06-13 14:06:41 UTC) #3
Jakob Kummerow
8 years, 6 months ago (2012-06-13 14:07:21 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698