Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: lib/compiler/implementation/ssa/nodes.dart

Issue 10544132: Revert r8592: failures on checked mode and some web tests. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/nodes.dart
===================================================================
--- lib/compiler/implementation/ssa/nodes.dart (revision 8593)
+++ lib/compiler/implementation/ssa/nodes.dart (working copy)
@@ -985,8 +985,6 @@
final int state;
final HType guardedType;
bool isOn = false;
- int checkedInputIndex = 0;
-
HTypeGuard(this.guardedType, this.state, List<HInstruction> env) : super(env);
void prepareGvn() {
@@ -994,7 +992,7 @@
setUseGvn();
}
- HInstruction get guarded() => inputs[checkedInputIndex];
+ HInstruction get guarded() => inputs.last();
HInstruction get checkedInput() => guarded;
HType computeTypeFromInputTypes() {
@@ -1008,9 +1006,7 @@
accept(HVisitor visitor) => visitor.visitTypeGuard(this);
int typeCode() => 1;
bool typeEquals(other) => other is HTypeGuard;
- bool dataEquals(HTypeGuard other) {
- return guarded == other.guarded && guardedType == other.guardedType;
- }
+ bool dataEquals(HTypeGuard other) => guardedType == other.guardedType;
}
class HBoundsCheck extends HCheck {
@@ -2495,10 +2491,6 @@
return condition.start;
}
- HBasicBlock get loopHeader() {
- return kind == DO_WHILE_LOOP ? body.start : condition.start;
- }
-
HBasicBlock get end() {
if (updates !== null) return updates.end;
if (kind == DO_WHILE_LOOP) {
« no previous file with comments | « lib/compiler/implementation/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698