Make new tab button color match inactive tab

Make new tab button color match inactive tab

Currently the new tab button is much brighter than the inactive tab background color.

The problem is that the tab strip code draws the new tab button background programatically. This means that the new tab button icon shouldn't have a fill.

This was working correctly but regressed in r134335.

Screenshots:
  before: http://i.imgur.com/iLGLN.png
  fixed: http://i.imgur.com/zVTaq.png

BUG=132333
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141805

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141974

[sky, 2012-06-12 21:50:40]

LGTM

[commit-bot: I haz the power, 2012-06-12 22:02:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10544117/10001

[James Cook, 2012-06-12 22:14:13]

On 2012/06/12 22:02:21, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/sail%40chromium.org/10544117/10001

Don't you need to update theme_resources_2x.grd as well, in order to ensure all
the resource IDs still match?

[commit-bot: I haz the power, 2012-06-12 22:16:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/10544117/10001

[sail, 2012-06-12 22:20:20]

On 2012/06/12 22:14:13, James Cook (Chromium) wrote:
> On 2012/06/12 22:02:21, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://chromium-status.appspot.com/cq/sail%2540chromium.org/10544117/10001
> 
> Don't you need to update theme_resources_2x.grd as well, in order to ensure
all
> the resource IDs still match?

The IDs match because the TOOLKIT_VIEWS conditions adds the same resources.
Hopefully this will go away in a few days when we make the same fix for ash.

[James Cook, 2012-06-12 23:15:44]

On 2012/06/12 22:20:20, sail wrote:
> On 2012/06/12 22:14:13, James Cook (Chromium) wrote:
> > On 2012/06/12 22:02:21, I haz the power (commit-bot) wrote:
> > > CQ is trying da patch. Follow status at
> > >
https://chromium-status.appspot.com/cq/sail%252540chromium.org/10544117/10001
> > 
> > Don't you need to update theme_resources_2x.grd as well, in order to ensure
> all
> > the resource IDs still match?
> 
> The IDs match because the TOOLKIT_VIEWS conditions adds the same resources.
> Hopefully this will go away in a few days when we make the same fix for ash.

OK, LGTM

[commit-bot: I haz the power, 2012-06-13 00:38:26]

Change committed as 141805

[flackr, 2012-06-13 19:38:04]

https://chromiumcodereview.appspot.com/10544117/diff/10001/chrome/app/theme/t...
File chrome/app/theme/theme_resources_standard.grd (right):

https://chromiumcodereview.appspot.com/10544117/diff/10001/chrome/app/theme/t...
chrome/app/theme/theme_resources_standard.grd:155: <if expr="not
pp_ifdef('toolkit_views') and not pp_ifdef('use_ash')">
This change broke running chrome with touch optimized UI. These changes should
be replicated in theme_resources_touch_1x.grd, theme_resources_touch_2x.grd and
theme_resources_2x.grd.

[sail, 2012-06-13 19:56:11]

On 2012/06/13 19:38:04, flackr wrote:
>
https://chromiumcodereview.appspot.com/10544117/diff/10001/chrome/app/theme/t...
> File chrome/app/theme/theme_resources_standard.grd (right):
> 
>
https://chromiumcodereview.appspot.com/10544117/diff/10001/chrome/app/theme/t...
> chrome/app/theme/theme_resources_standard.grd:155: <if expr="not
> pp_ifdef('toolkit_views') and not pp_ifdef('use_ash')">
> This change broke running chrome with touch optimized UI. These changes should
> be replicated in theme_resources_touch_1x.grd, theme_resources_touch_2x.grd
and
> theme_resources_2x.grd.

Hi Robert, sorry for breaking touch UI. James is working on cleaning this up. I
think that should fix your problem.

[sail, 2012-06-13 20:08:37]

On 2012/06/13 19:56:11, sail wrote:
> On 2012/06/13 19:38:04, flackr wrote:
> >
>
https://chromiumcodereview.appspot.com/10544117/diff/10001/chrome/app/theme/t...
> > File chrome/app/theme/theme_resources_standard.grd (right):
> > 
> >
>
https://chromiumcodereview.appspot.com/10544117/diff/10001/chrome/app/theme/t...
> > chrome/app/theme/theme_resources_standard.grd:155: <if expr="not
> > pp_ifdef('toolkit_views') and not pp_ifdef('use_ash')">
> > This change broke running chrome with touch optimized UI. These changes
should
> > be replicated in theme_resources_touch_1x.grd, theme_resources_touch_2x.grd
> and
> > theme_resources_2x.grd.
> 
> Hi Robert, sorry for breaking touch UI. James is working on cleaning this up.
I
> think that should fix your problem.

Never mind, thakis reverted.