Omnibox: In UMA logs, record typed_count of URLS.

Omnibox: In UMA logs, record typed_count of URLS.

For UMA opted-in users, record the typed_counts of users that show up as omnibox suggestions.

This has been approved by the privacy folks.

BUG=
TEST=using VLOG in the appropriate place in metrics_base.cc


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141787

[Ilya Sherman, 2012-06-12 21:25:10]

LGTM

http://codereview.chromium.org/10544114/diff/1/chrome/common/metrics/proto/om...
File chrome/common/metrics/proto/omnibox_event.proto (right):

http://codereview.chromium.org/10544114/diff/1/chrome/common/metrics/proto/om...
chrome/common/metrics/proto/omnibox_event.proto:126: optional int32 typed_count
= 5;
nit: Since you're adding this out of sequential order, please add a "Next tag:
6" comment above this message.

[Mark P, 2012-06-12 21:53:49]

http://codereview.chromium.org/10544114/diff/1/chrome/common/metrics/proto/om...
File chrome/common/metrics/proto/omnibox_event.proto (right):

http://codereview.chromium.org/10544114/diff/1/chrome/common/metrics/proto/om...
chrome/common/metrics/proto/omnibox_event.proto:126: optional int32 typed_count
= 5;
On 2012/06/12 21:25:10, Ilya Sherman wrote:
> nit: Since you're adding this out of sequential order, please add a "Next tag:
> 6" comment above this message.

Done.

[Peter Kasting, 2012-06-12 21:56:04]

LGTM

http://codereview.chromium.org/10544114/diff/1/chrome/browser/autocomplete/au...
File chrome/browser/autocomplete/autocomplete_match.h (right):

http://codereview.chromium.org/10544114/diff/1/chrome/browser/autocomplete/au...
chrome/browser/autocomplete/autocomplete_match.h:208: // it's  value is -1.  At
the time of writing this comment, it is only
Nit: Drop apostrophe and extra space.

[Mark P, 2012-06-12 21:58:02]

http://codereview.chromium.org/10544114/diff/1/chrome/browser/autocomplete/au...
File chrome/browser/autocomplete/autocomplete_match.h (right):

http://codereview.chromium.org/10544114/diff/1/chrome/browser/autocomplete/au...
chrome/browser/autocomplete/autocomplete_match.h:208: // it's  value is -1.  At
the time of writing this comment, it is only
On 2012/06/12 21:56:04, Peter Kasting wrote:
> Nit: Drop apostrophe and extra space.

Done.

[commit-bot: I haz the power, 2012-06-12 21:58:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/10544114/6002

[commit-bot: I haz the power, 2012-06-12 23:36:16]

Change committed as 141787