Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 10544095: Add files and exclusions needed for NaCl IPC proxy to base_untrusted target. (Closed)

Created:
8 years, 6 months ago by bbudge
Modified:
8 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Add files and exclusions needed for NaCl IPC proxy to base_untrusted target. BUG=116317 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141613

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M base/base.gypi View 1 4 chunks +26 lines, -2 lines 0 comments Download
M base/base_untrusted.gyp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M build/filename_rules.gypi View 1 2 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
bbudge
I think the conversion of the existing .gyp files is difficult enough that I'll split ...
8 years, 6 months ago (2012-06-11 18:04:04 UTC) #1
brettw
Is it possible to do this via exclusion so the list of files can be ...
8 years, 6 months ago (2012-06-11 19:08:50 UTC) #2
bbudge
Changed conditions so POSIX and NaCl files are included in nacl_untrusted_build targets. Unwanted files are ...
8 years, 6 months ago (2012-06-11 22:33:05 UTC) #3
brettw
lgtm
8 years, 6 months ago (2012-06-11 22:36:53 UTC) #4
bbudge
The previous change excluded 'nacl/' directories. Unfortunately, there are some 'nacl/' directories already present since ...
8 years, 6 months ago (2012-06-11 23:48:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bbudge@chromium.org/10544095/11002
8 years, 6 months ago (2012-06-12 01:43:34 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 04:02:58 UTC) #7
Change committed as 141613

Powered by Google App Engine
This is Rietveld 408576698